Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: chrome/browser/ui/webui/settings/settings_default_browser_handler.cc

Issue 2846043002: MD Settings: fix policy control detection on default browser section (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/settings_default_browser_handler.h" 5 #include "chrome/browser/ui/webui/settings/settings_default_browser_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/metrics/user_metrics.h" 9 #include "base/metrics/user_metrics.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
11 #include "chrome/browser/ui/startup/default_browser_prompt.h" 11 #include "chrome/browser/ui/startup/default_browser_prompt.h"
12 #include "chrome/common/pref_names.h" 12 #include "chrome/common/pref_names.h"
13 #include "components/prefs/pref_service.h" 13 #include "components/prefs/pref_service.h"
14 #include "content/public/browser/web_ui.h" 14 #include "content/public/browser/web_ui.h"
15 15
16 namespace settings { 16 namespace settings {
17 17
18 namespace { 18 namespace {
19 19
20 bool DefaultBrowserIsDisabledByPolicy() { 20 bool DefaultBrowserIsDisabledByPolicy() {
21 const PrefService::Preference* pref = 21 const PrefService::Preference* pref =
22 g_browser_process->local_state()->FindPreference( 22 g_browser_process->local_state()->FindPreference(
23 prefs::kDefaultBrowserSettingEnabled); 23 prefs::kDefaultBrowserSettingEnabled);
24 DCHECK(pref); 24 DCHECK(pref);
25 return pref->IsManaged() && !pref->GetValue(); 25 bool may_set_default_browser;
26 bool success = pref->GetValue()->GetAsBoolean(&may_set_default_browser);
27 DCHECK(success);
28 return pref->IsManaged() && !may_set_default_browser;
26 } 29 }
27 30
28 } // namespace 31 } // namespace
29 32
30 DefaultBrowserHandler::DefaultBrowserHandler(content::WebUI* webui) 33 DefaultBrowserHandler::DefaultBrowserHandler(content::WebUI* webui)
31 : weak_ptr_factory_(this) { 34 : weak_ptr_factory_(this) {
32 default_browser_worker_ = new shell_integration::DefaultBrowserWorker( 35 default_browser_worker_ = new shell_integration::DefaultBrowserWorker(
33 base::Bind(&DefaultBrowserHandler::OnDefaultBrowserWorkerFinished, 36 base::Bind(&DefaultBrowserHandler::OnDefaultBrowserWorkerFinished,
34 weak_ptr_factory_.GetWeakPtr())); 37 weak_ptr_factory_.GetWeakPtr()));
35 } 38 }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 dict.SetBoolean("isUnknownError", 98 dict.SetBoolean("isUnknownError",
96 state == shell_integration::UNKNOWN_DEFAULT); 99 state == shell_integration::UNKNOWN_DEFAULT);
97 dict.SetBoolean("isDisabledByPolicy", DefaultBrowserIsDisabledByPolicy()); 100 dict.SetBoolean("isDisabledByPolicy", DefaultBrowserIsDisabledByPolicy());
98 101
99 CallJavascriptFunction("cr.webUIListenerCallback", 102 CallJavascriptFunction("cr.webUIListenerCallback",
100 base::Value("settings.updateDefaultBrowserState"), 103 base::Value("settings.updateDefaultBrowserState"),
101 dict); 104 dict);
102 } 105 }
103 106
104 } // namespace settings 107 } // namespace settings
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698