components/password_manager/core/browser/password_store_default_unittest.cc - Issue 2846023003: Creating a preference for storing a sync password hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 2846023003: Creating a preference for storing a sync password hash. (Closed)

Patch Set: Reviewer's comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_default.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc

index f8239e5ceba581915b1d98ee6492bb5538786395..24b05c21e2f648276460f1e5ba9144d1e9e2f518 100644

--- a/components/password_manager/core/browser/password_store_default_unittest.cc

+++ b/components/password_manager/core/browser/password_store_default_unittest.cc

@@ -140,7 +140,7 @@ PasswordStoreDefaultTestDelegate::CreateInitializedStore(

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

std::move(database)));

- store->Init(syncer::SyncableService::StartSyncFlare());

+ store->Init(syncer::SyncableService::StartSyncFlare(), nullptr);

return store;

}