components/password_manager/core/browser/password_manager_unittest.cc - Issue 2846023003: Creating a preference for storing a sync password hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 2846023003: Creating a preference for storing a sync password hash. (Closed)

Patch Set: Reviewer's comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_test_utils.h ('k') | components/password_manager/core/browser/password_reuse_detection_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index 668303a45f56b902d6b9c0cec50d92ed06c84588..c77318ce450457d77416a2fbc300a60b280f235b 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -119,7 +119,7 @@ class PasswordManagerTest : public testing::Test {

void SetUp() override {

store_ = new testing::StrictMock<MockPasswordStore>;

EXPECT_CALL(*store_, ReportMetrics(_, _)).Times(AnyNumber());

- CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));

+ CHECK(store_->Init(syncer::SyncableService::StartSyncFlare(), nullptr));

EXPECT_CALL(client_, GetPasswordStore())

.WillRepeatedly(Return(store_.get()));