components/password_manager/core/browser/password_manager.cc - Issue 2846023003: Creating a preference for storing a sync password hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2846023003: Creating a preference for storing a sync password hash. (Closed)

Patch Set: Reviewer's comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index dae64390d357748be23ebfcbb84719df4c4d9b2c..372aa78e491ad92eabb31be38ef24abd11e1104d 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -155,6 +155,8 @@ void PasswordManager::RegisterProfilePrefs(

prefs::kCredentialsEnableAutosignin, true,

user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);

registry->RegisterBooleanPref(prefs::kWasObsoleteHttpDataCleaned, false);

+ registry->RegisterStringPref(prefs::kSyncPasswordHash, std::string(),

+ PrefRegistry::NO_REGISTRATION_FLAGS);

#if defined(OS_MACOSX)

registry->RegisterIntegerPref(

prefs::kKeychainMigrationStatus,