chrome/browser/password_manager/password_store_proxy_mac_unittest.cc - Issue 2846023003: Creating a preference for storing a sync password hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

Issue 2846023003: Creating a preference for storing a sync password hash. (Closed)

Patch Set: Reviewer's comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_proxy_mac.cc ('k') | chrome/browser/password_manager/password_store_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

index 55090fdbb1b365c28923024face63ac99a58608f..6ee8526f14552c8d8c435b83721d609e8cac5803 100644

--- a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

+++ b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

@@ -182,7 +182,7 @@ void PasswordStoreProxyMacTest::CreateAndInitPasswordStore(

BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),

base::MakeUnique<crypto::MockAppleKeychain>(), std::move(login_db),

&testing_prefs_);

- ASSERT_TRUE(store_->Init(syncer::SyncableService::StartSyncFlare()));

+ ASSERT_TRUE(store_->Init(syncer::SyncableService::StartSyncFlare(), nullptr));

}

void PasswordStoreProxyMacTest::ClosePasswordStore() {

@@ -480,7 +480,7 @@ void PasswordStoreProxyMacMigrationTest::TestMigration(bool lock_keychain) {

store_ = new PasswordStoreProxyMac(

BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),

std::move(keychain_), std::move(login_db_), &testing_prefs_);

- ASSERT_TRUE(store_->Init(syncer::SyncableService::StartSyncFlare()));

+ ASSERT_TRUE(store_->Init(syncer::SyncableService::StartSyncFlare(), nullptr));

FinishAsyncProcessing();

MockPasswordStoreConsumer mock_consumer;