Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 2846023003: Creating a preference for storing a sync password hash. (Closed)
Patch Set: Reviewer's comments addressed Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_mac.h" 5 #include "chrome/browser/password_manager/password_store_mac.h"
6 6
7 #include <CoreServices/CoreServices.h> 7 #include <CoreServices/CoreServices.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <algorithm> 9 #include <algorithm>
10 #include <iterator> 10 #include <iterator>
(...skipping 1019 matching lines...) Expand 10 before | Expand all | Expand 10 after
1030 } 1030 }
1031 1031
1032 void PasswordStoreMac::set_login_metadata_db( 1032 void PasswordStoreMac::set_login_metadata_db(
1033 password_manager::LoginDatabase* login_db) { 1033 password_manager::LoginDatabase* login_db) {
1034 login_metadata_db_ = login_db; 1034 login_metadata_db_ = login_db;
1035 if (login_metadata_db_) 1035 if (login_metadata_db_)
1036 login_metadata_db_->set_clear_password_values(true); 1036 login_metadata_db_->set_clear_password_values(true);
1037 } 1037 }
1038 1038
1039 bool PasswordStoreMac::Init( 1039 bool PasswordStoreMac::Init(
1040 const syncer::SyncableService::StartSyncFlare& flare) { 1040 const syncer::SyncableService::StartSyncFlare& flare,
1041 PrefService* prefs) {
1041 // The class should be used inside PasswordStoreProxyMac only. 1042 // The class should be used inside PasswordStoreProxyMac only.
1042 NOTREACHED(); 1043 NOTREACHED();
1043 return true; 1044 return true;
1044 } 1045 }
1045 1046
1046 void PasswordStoreMac::ReportMetricsImpl(const std::string& sync_username, 1047 void PasswordStoreMac::ReportMetricsImpl(const std::string& sync_username,
1047 bool custom_passphrase_sync_enabled) { 1048 bool custom_passphrase_sync_enabled) {
1048 if (!login_metadata_db_) 1049 if (!login_metadata_db_)
1049 return; 1050 return;
1050 login_metadata_db_->ReportMetrics(sync_username, 1051 login_metadata_db_->ReportMetrics(sync_username,
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
1378 std::vector<std::unique_ptr<PasswordForm>> forms_with_keychain_entry; 1379 std::vector<std::unique_ptr<PasswordForm>> forms_with_keychain_entry;
1379 internal_keychain_helpers::GetPasswordsForForms(*keychain_, &database_forms, 1380 internal_keychain_helpers::GetPasswordsForForms(*keychain_, &database_forms,
1380 &forms_with_keychain_entry); 1381 &forms_with_keychain_entry);
1381 1382
1382 // Clean up any orphaned database entries. 1383 // Clean up any orphaned database entries.
1383 RemoveDatabaseForms(&database_forms); 1384 RemoveDatabaseForms(&database_forms);
1384 1385
1385 // Move the orphaned DB forms to the output parameter. 1386 // Move the orphaned DB forms to the output parameter.
1386 AppendSecondToFirst(orphaned_forms, &database_forms); 1387 AppendSecondToFirst(orphaned_forms, &database_forms);
1387 } 1388 }
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.h ('k') | chrome/browser/password_manager/password_store_proxy_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698