Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 2846023003: Creating a preference for storing a sync password hash. (Closed)
Patch Set: Reviewer's comments addressed Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_mac.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_factory.h" 5 #include "chrome/browser/password_manager/password_store_factory.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 ps = new PasswordStoreX(main_thread_runner, db_thread_runner, 255 ps = new PasswordStoreX(main_thread_runner, db_thread_runner,
256 std::move(login_db), backend.release()); 256 std::move(login_db), backend.release());
257 RecordBackendStatistics(desktop_env, store_type, used_backend); 257 RecordBackendStatistics(desktop_env, store_type, used_backend);
258 #elif defined(USE_OZONE) 258 #elif defined(USE_OZONE)
259 ps = new password_manager::PasswordStoreDefault( 259 ps = new password_manager::PasswordStoreDefault(
260 main_thread_runner, db_thread_runner, std::move(login_db)); 260 main_thread_runner, db_thread_runner, std::move(login_db));
261 #else 261 #else
262 NOTIMPLEMENTED(); 262 NOTIMPLEMENTED();
263 #endif 263 #endif
264 DCHECK(ps); 264 DCHECK(ps);
265 if (!ps->Init( 265 if (!ps->Init(sync_start_util::GetFlareForSyncableService(profile->GetPath()),
266 sync_start_util::GetFlareForSyncableService(profile->GetPath()))) { 266 profile->GetPrefs())) {
267 // TODO(crbug.com/479725): Remove the LOG once this error is visible in the 267 // TODO(crbug.com/479725): Remove the LOG once this error is visible in the
268 // UI. 268 // UI.
269 LOG(WARNING) << "Could not initialize password store."; 269 LOG(WARNING) << "Could not initialize password store.";
270 return nullptr; 270 return nullptr;
271 } 271 }
272 272
273 password_manager::DelayCleanObsoleteHttpDataForPasswordStoreAndPrefs( 273 password_manager::DelayCleanObsoleteHttpDataForPasswordStoreAndPrefs(
274 ps.get(), profile->GetPrefs(), 274 ps.get(), profile->GetPrefs(),
275 make_scoped_refptr(profile->GetRequestContext())); 275 make_scoped_refptr(profile->GetRequestContext()));
276 276
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 break; 356 break;
357 case LIBSECRET: 357 case LIBSECRET:
358 usage = OTHER_LIBSECRET; 358 usage = OTHER_LIBSECRET;
359 break; 359 break;
360 } 360 }
361 } 361 }
362 UMA_HISTOGRAM_ENUMERATION("PasswordManager.LinuxBackendStatistics", usage, 362 UMA_HISTOGRAM_ENUMERATION("PasswordManager.LinuxBackendStatistics", usage,
363 MAX_BACKEND_USAGE_VALUE); 363 MAX_BACKEND_USAGE_VALUE);
364 } 364 }
365 #endif 365 #endif
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698