third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-1.html - Issue 2845983002: [modules] Add several new WPT tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-1.html

Issue 2845983002: [modules] Add several new WPT tests. (Closed)

Patch Set: Test scriptEl.onload in instantiation-error-*.html. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>html-script-module-fetch-error-1</title>

	3

	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

	6 <script>

	7 var log = [];

	8

	9 var test_load = async_test("test_load");

	10 window.addEventListener("load", test_load.step_func_done(ev => {

	11 assert_array_equals(log, ["script"]);

	12 }));

	13

	14 // TODO(neis): Test properties of the error event?
	domenic 2017/05/03 23:49:30 As we discussed over email, you can do this by cha As we discussed over email, you can do this by changing to onerror="log.push(event)". Then I'd just test `assert_equals(log[1].constructor, window.Event)` (i.e. it's supposed to be plain old' Event, not an ErrorEvent). Yes, it's not great that onerror means one thing for nodes and another thing for global scopes. (Especially because as you found one onerror can bubble up to Windows from Nodes.) If we were doing the web over we'd probably rename the global one "scripterror" or something.
	15 </script>

	16 <script type="module" src="./no-such-file.js" onerror="log.push('script')"></scr ipt>

OLD	NEW