third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO - Issue 2845983002: [modules] Add several new WPT tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO

Issue 2845983002: [modules] Add several new WPT tests. (Closed)

Patch Set: Test scriptEl.onload in instantiation-error-*.html. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 - In some cases we check that all logged exceptions are the same.

	2 Should even the error events be the same?
	domenic 2017/05/03 23:49:29 Error events should not be the same. Testing that Error events should not be the same. Testing that they're different might be valuable. You don't have to do that, but it would be good to update the TODO :)
	3

	4 - Do we want to assert that the load event is fired only once?

	5

	6 - Some obvious areas where more (or even any) tests are needed:

	7 * scriptEl.onerror

	8 * scriptEl.onload

	9 * defer

	10 * Invalid module specifiers.

	11 * Fetch errors.
	domenic 2017/05/03 23:49:29 Microsoft has a lot of tests for these (e.g. diffe Microsoft has a lot of tests for these (e.g. different server errors; bad MIME types), but they might need updating for the spec changes.
	12 * Inline module scripts (once implemented).

OLD	NEW