third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-1.html - Issue 2845983002: [modules] Add several new WPT tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-1.html

Issue 2845983002: [modules] Add several new WPT tests. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-success-4.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-success-7.html ('k') | third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-1.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-1.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>html-script-module-fetch-error-1</title>

	5 <script src="/resources/testharness.js"></script>

	6 <script src="/resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <h1>html-script-module-fetch-error-1</h1>

	10 <script>

	11

	12 var log = [];

	13

	14 var test_load = async_test("test_load");

	15 window.addEventListener("load", test_load.step_func_done(ev => {

	16 assert_equals(log.length, 1);

	17 assert_false(true);
	domenic 2017/04/28 20:12:03 What is this assert_false(true) about? What is this assert_false(true) about? neis 2017/05/02 13:51:59 Oops, I didn't intend to include this file actuall Show quoted text On 2017/04/28 20:12:03, domenic wrote: > What is this assert_false(true) about? Oops, I didn't intend to include this file actually.
	18 // TODO(neis): Check more?

	19 }));

	20

	21 var test_error = async_test("test_error");

	22 window.addEventListener("error", test_error.step_func_done(ev => {
	domenic 2017/04/28 20:12:03 Per latest changes this should not fire; it woul Per latest changes this should not fire; it would be good to test that it doesn't, in fact. I guess that's automatically accomplished by not setting allow_uncaught_exception. neis 2017/05/02 13:51:59 I believe it should fire because it's not being ha Show quoted text On 2017/04/28 20:12:03, domenic wrote: > Per latest changes this should not fire; it would be good to test that it > doesn't, in fact. I guess that's automatically accomplished by not setting > allow_uncaught_exception. I believe it should fire because it's not being handled by the script, right? I changed the test now such that the script handles it. And yes, not setting the allow_uncaught_exception ensures that there's no separate window.error event. Are there any properties of the event object that we'd like to test? (Is it expected to have an "error" property?)
	23 log.push(ev);

	24 }));

	25

	26 </script>

	27 // TODO(neis): Check script's onerror.

	28 <script type="module" src="./no-such-file.js"></script>

	29 </body>

	30 </html>

OLD	NEW