third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/compilation-error-1.html - Issue 2845983002: [modules] Add several new WPT tests.

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/compilation-error-1.html

Issue 2845983002: [modules] Add several new WPT tests. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO ('K') | « third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO ('k') | third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/compilation-error-2.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/compilation-error-2.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>
	domenic 2017/04/28 20:12:02 General style guidelines: the Microsoft tests have General style guidelines: the Microsoft tests have a lot of boilerplate you don't need, such as <html>, <head>, <body>, <h1>, indentation. I'd suggest drawing inspiration from my tests, e.g. https://github.com/w3c/web-platform-tests/blob/master/html/infrastructure/saf... . Of note, the help/author links are optional, and the <meta charset> doesn't matter much either. This isn't an important issue---there is no style enforcement for WPT---but I thought maybe you would appreciate not having to do all that stuff. No need to reformat after you've already written things up, certainly. Although I think more informative <title>s would probably help people.
	3 <head>

	4 <title>html-script-module-compilation-error-1</title>

	5 <script src="/resources/testharness.js"></script>

	6 <script src="/resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <h1>html-script-module-compilation-error-1</h1>

	10 <script>

	11

	12 setup({allow_uncaught_exception: true});

	13

	14 window.addEventListener("error", ev => log.push(ev.error));

	15

	16 var log = [];

	17

	18 var test_load = async_test("test_load");
	domenic 2017/04/28 20:12:02 Test names should be informative, e.g. "Syntax err Test names should be informative, e.g. "Syntax errors cause error events on module script elements" or similar. You can also take the below advice about removing the async_test entirely (using single-page tests) and in that case move the description into the <title>
	19 window.addEventListener("load", test_load.step_func_done(ev => {

	20 assert_equals(log.length, 2);
	domenic 2017/04/28 20:12:02 This should be 5, I believe. The script is in an e This should be 5, I believe. The script is in an errored state. neis 2017/05/02 13:51:59 Done. Show quoted text On 2017/04/28 20:12:02, domenic wrote: > This should be 5, I believe. The script is in an errored state. Done.
	21 assert_true(log[0] instanceof SyntaxError);
	domenic 2017/04/28 20:12:02 This might be better as assert_equals(log[0].const This might be better as assert_equals(log[0].constructor, SyntaxError)
	22 assert_true(log.every(exn => exn === log[0]));
	domenic 2017/04/28 20:12:02 For assert_true, I like giving a message so that i For assert_true, I like giving a message so that if it fails you get something more informative than "expected true got false".
	23 }));
	domenic 2017/04/28 20:12:02 Since this is a single test, you can omit the asyn Since this is a single test, you can omit the async_test stuff and just call done() when the test is done (i.e. after the assert_true). See "Single Page Test" on http://web-platform-tests.org/writing-tests/testharness-api.html neis 2017/05/02 13:51:59 I wasn't able to make this work. Even without call Show quoted text On 2017/04/28 20:12:02, domenic wrote: > Since this is a single test, you can omit the async_test stuff and just call > done() when the test is done (i.e. after the assert_true). See "Single Page > Test" on http://web-platform-tests.org/writing-tests/testharness-api.html I wasn't able to make this work. Even without calling done(), the test passed.
	24

	25 </script>

	26 <script type="module" src="./syntaxerror.js"></script>
	domenic 2017/04/28 20:12:02 We should add onerror="assert_unreached('1st')" et We should add onerror="assert_unreached('1st')" etc. since onerror should never be fired for these. We should do that for every test that isn't testing fetching errors. neis 2017/05/02 13:51:59 assert_unreached() didn't work for me, that's why Show quoted text On 2017/04/28 20:12:02, domenic wrote: > We should add onerror="assert_unreached('1st')" etc. since onerror should never > be fired for these. We should do that for every test that isn't testing fetching > errors. assert_unreached() didn't work for me, that's why I used my own unreachable() function. I added it to all appropriate script tags now.
	27 <script type="module" src="./syntaxerror.js"></script>

	28 <script type="module" src="./syntaxerror-nested.js"></script>

	29 <script type="module" src="./syntaxerror.js"></script>

	30 <script type="module" src="./syntaxerror-nested.js"></script>

	31 </body>

	32 </html>

OLD	NEW