OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chromeos/network/network_sms_handler.h" | 5 #include "chromeos/network/network_sms_handler.h" |
6 | 6 |
7 #include <memory> | 7 #include <memory> |
8 #include <set> | 8 #include <set> |
9 #include <string> | 9 #include <string> |
10 | 10 |
11 #include "base/command_line.h" | 11 #include "base/command_line.h" |
12 #include "base/message_loop/message_loop.h" | |
13 #include "base/run_loop.h" | 12 #include "base/run_loop.h" |
| 13 #include "base/test/scoped_task_environment.h" |
14 #include "chromeos/chromeos_switches.h" | 14 #include "chromeos/chromeos_switches.h" |
15 #include "chromeos/dbus/dbus_thread_manager.h" | 15 #include "chromeos/dbus/dbus_thread_manager.h" |
16 #include "chromeos/dbus/shill_device_client.h" | 16 #include "chromeos/dbus/shill_device_client.h" |
17 #include "testing/gtest/include/gtest/gtest.h" | 17 #include "testing/gtest/include/gtest/gtest.h" |
18 #include "third_party/cros_system_api/dbus/service_constants.h" | 18 #include "third_party/cros_system_api/dbus/service_constants.h" |
19 | 19 |
20 namespace chromeos { | 20 namespace chromeos { |
21 | 21 |
22 namespace { | 22 namespace { |
23 | 23 |
(...skipping 20 matching lines...) Expand all Loading... |
44 } | 44 } |
45 | 45 |
46 private: | 46 private: |
47 std::set<std::string> messages_; | 47 std::set<std::string> messages_; |
48 }; | 48 }; |
49 | 49 |
50 } // namespace | 50 } // namespace |
51 | 51 |
52 class NetworkSmsHandlerTest : public testing::Test { | 52 class NetworkSmsHandlerTest : public testing::Test { |
53 public: | 53 public: |
54 NetworkSmsHandlerTest() {} | 54 NetworkSmsHandlerTest() |
| 55 : scoped_task_environment_( |
| 56 base::test::ScopedTaskEnvironment::MainThreadType::UI) {} |
55 ~NetworkSmsHandlerTest() override {} | 57 ~NetworkSmsHandlerTest() override {} |
56 | 58 |
57 void SetUp() override { | 59 void SetUp() override { |
58 // Append '--sms-test-messages' to the command line to tell | 60 // Append '--sms-test-messages' to the command line to tell |
59 // SMSClientStubImpl to generate a series of test SMS messages. | 61 // SMSClientStubImpl to generate a series of test SMS messages. |
60 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); | 62 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); |
61 command_line->AppendSwitch(chromeos::switches::kSmsTestMessages); | 63 command_line->AppendSwitch(chromeos::switches::kSmsTestMessages); |
62 | 64 |
63 // Initialize DBusThreadManager with a stub implementation. | 65 // Initialize DBusThreadManager with a stub implementation. |
64 DBusThreadManager::Initialize(); | 66 DBusThreadManager::Initialize(); |
(...skipping 16 matching lines...) Expand all Loading... |
81 base::RunLoop().RunUntilIdle(); | 83 base::RunLoop().RunUntilIdle(); |
82 } | 84 } |
83 | 85 |
84 void TearDown() override { | 86 void TearDown() override { |
85 network_sms_handler_->RemoveObserver(test_observer_.get()); | 87 network_sms_handler_->RemoveObserver(test_observer_.get()); |
86 network_sms_handler_.reset(); | 88 network_sms_handler_.reset(); |
87 DBusThreadManager::Shutdown(); | 89 DBusThreadManager::Shutdown(); |
88 } | 90 } |
89 | 91 |
90 protected: | 92 protected: |
91 base::MessageLoopForUI message_loop_; | 93 base::test::ScopedTaskEnvironment scoped_task_environment_; |
92 std::unique_ptr<NetworkSmsHandler> network_sms_handler_; | 94 std::unique_ptr<NetworkSmsHandler> network_sms_handler_; |
93 std::unique_ptr<TestObserver> test_observer_; | 95 std::unique_ptr<TestObserver> test_observer_; |
94 }; | 96 }; |
95 | 97 |
96 TEST_F(NetworkSmsHandlerTest, SmsHandlerDbusStub) { | 98 TEST_F(NetworkSmsHandlerTest, SmsHandlerDbusStub) { |
97 EXPECT_EQ(test_observer_->message_count(), 0); | 99 EXPECT_EQ(test_observer_->message_count(), 0); |
98 | 100 |
99 // Test that no messages have been received yet | 101 // Test that no messages have been received yet |
100 const std::set<std::string>& messages(test_observer_->messages()); | 102 const std::set<std::string>& messages(test_observer_->messages()); |
101 // Note: The following string corresponds to values in | 103 // Note: The following string corresponds to values in |
102 // ModemMessagingClientStubImpl and SmsClientStubImpl. | 104 // ModemMessagingClientStubImpl and SmsClientStubImpl. |
103 // TODO(stevenjb): Use a TestInterface to set this up to remove dependency. | 105 // TODO(stevenjb): Use a TestInterface to set this up to remove dependency. |
104 const char kMessage1[] = "FakeSMSClient: Test Message: /SMS/0"; | 106 const char kMessage1[] = "FakeSMSClient: Test Message: /SMS/0"; |
105 EXPECT_EQ(messages.find(kMessage1), messages.end()); | 107 EXPECT_EQ(messages.find(kMessage1), messages.end()); |
106 | 108 |
107 // Test for messages delivered by signals. | 109 // Test for messages delivered by signals. |
108 test_observer_->ClearMessages(); | 110 test_observer_->ClearMessages(); |
109 network_sms_handler_->RequestUpdate(false); | 111 network_sms_handler_->RequestUpdate(false); |
110 base::RunLoop().RunUntilIdle(); | 112 base::RunLoop().RunUntilIdle(); |
111 EXPECT_GE(test_observer_->message_count(), 1); | 113 EXPECT_GE(test_observer_->message_count(), 1); |
112 EXPECT_NE(messages.find(kMessage1), messages.end()); | 114 EXPECT_NE(messages.find(kMessage1), messages.end()); |
113 } | 115 } |
114 | 116 |
115 } // namespace chromeos | 117 } // namespace chromeos |
OLD | NEW |