third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h - Issue 2845963002: [ServiceWorker] Add type attribute into Client object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

Issue 2845963002: [ServiceWorker] Add type attribute into Client object (Closed)

Patch Set: Address comments from foolip@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/Client.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

index bb5a3515ad26553fce148037e9eee6188f02dd89..22e7129b07f5aaaf321ba6868dcb3cf87c6d7e6e 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

@@ -36,6 +36,7 @@ class MODULES_EXPORT ServiceWorkerClient

// Client.idl

String url() const { return url_; }

+ String type() const;

String frameType() const;

String id() const { return uuid_; }

void postMessage(ScriptState*,

@@ -55,6 +56,7 @@ class MODULES_EXPORT ServiceWorkerClient

private:

String uuid_;

String url_;

+ WebServiceWorkerClientType type_;

WebURLRequest::FrameType frame_type_;

};