third_party/WebKit/Source/modules/serviceworkers/Client.idl - Issue 2845963002: [ServiceWorker] Add type attribute into Client object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/Client.idl

Issue 2845963002: [ServiceWorker] Add type attribute into Client object (Closed)

Patch Set: Fix layout tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/ServiceWorker/#service-worker-client-interface	5 // https://w3c.github.io/ServiceWorker/#service-worker-client-interface
	foolip 2017/05/03 15:18:10 Can you update this link to https://w3c.github.io/ Can you update this link to https://w3c.github.io/ServiceWorker/#client-interface? I tried following it but it's stale. leonhsl(Using Gerrit) 2017/05/04 03:18:05 Done. Show quoted text On 2017/05/03 15:18:10, foolip wrote: > Can you update this link to > https://w3c.github.io/ServiceWorker/#client-interface? I tried following it but > it's stale. Done.
6 [	6 [

7 Exposed=ServiceWorker,	7 Exposed=ServiceWorker,

8 ImplementedAs=ServiceWorkerClient,	8 ImplementedAs=ServiceWorkerClient,

9 ] interface Client {	9 ] interface Client {

10 readonly attribute USVString url;	10 readonly attribute USVString url;

	11 readonly attribute ClientType type;
	foolip 2017/05/03 15:18:10 Please match the order of attributes in the spec. Please match the order of attributes in the spec. leonhsl(Using Gerrit) 2017/05/04 03:18:04 Done. Show quoted text On 2017/05/03 15:18:10, foolip wrote: > Please match the order of attributes in the spec. Done.
11 readonly attribute ContextFrameType frameType;	12 readonly attribute ContextFrameType frameType;
	foolip 2017/05/03 15:18:10 If frameType isn't in the spec, please file a bug If frameType isn't in the spec, please file a bug for it and put it in a "Non-standard" section at the bottom of the interface. leonhsl(Using Gerrit) 2017/05/04 03:18:05 Done. Put frameType into a "Non-standard" section Show quoted text On 2017/05/03 15:18:10, foolip wrote: > If frameType isn't in the spec, please file a bug for it and put it in a > "Non-standard" section at the bottom of the interface. Done. Put frameType into a "Non-standard" section at the bottom. There is an existing bug https://crbug.com/697110 tracking the removal of frameType.
12 readonly attribute DOMString id;	13 readonly attribute DOMString id;

13 [PostMessage, RaisesException, CallWith=ScriptState] void postMessage(Serial izedScriptValue message, optional sequence<Transferable> transfer);	14 [PostMessage, RaisesException, CallWith=ScriptState] void postMessage(Serial izedScriptValue message, optional sequence<Transferable> transfer);

14 };	15 };

OLD	NEW