[ServiceWorker] Add type attribute into Client object

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/serviceworkers/ServiceWorkerClient.h"
 #include "modules/serviceworkers/ServiceWorkerWindowClient.h"
 
 #include <memory>
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ExceptionState.h"
@@ skipping 27 matching lines @@
 }
 
 ServiceWorkerClient* ServiceWorkerClient::Create(
     const WebServiceWorkerClientInfo& info) {
   return new ServiceWorkerClient(info);
 }
 
 ServiceWorkerClient::ServiceWorkerClient(const WebServiceWorkerClientInfo& info)
     : uuid_(info.uuid),
       url_(info.url.GetString()),
+      type_(info.client_type),
       frame_type_(info.frame_type) {}
 
 ServiceWorkerClient::~ServiceWorkerClient() {}
 
+String ServiceWorkerClient::type() const {
+  switch (type_) {
+    case kWebServiceWorkerClientTypeWindow:
+      return "window";
+    case kWebServiceWorkerClientTypeWorker:
+      return "worker";
+    case kWebServiceWorkerClientTypeSharedWorker:
+      return "sharedworker";
+    case kWebServiceWorkerClientTypeLast:

[shimazu, 2017/05/01 06:40:35]

I prefer kWebServiceWorkerClientTypeAll to Last to clarify what is prohibited.
Just removing this case looks also good.

[leonhsl(Using Gerrit), 2017/05/02 03:14:35]

Done.

+      NOTREACHED();
+      return String();
+  }
+
+  NOTREACHED();
+  return String();
+}
+
 String ServiceWorkerClient::frameType() const {
   switch (frame_type_) {
     case WebURLRequest::kFrameTypeAuxiliary:
       return "auxiliary";
     case WebURLRequest::kFrameTypeNested:
       return "nested";
     case WebURLRequest::kFrameTypeNone:
       return "none";
     case WebURLRequest::kFrameTypeTopLevel:
       return "top-level";
@@ skipping 15 matching lines @@
     return;
 
   WebString message_string = message->ToWireString();
   WebMessagePortChannelArray web_channels =
       MessagePort::ToWebMessagePortChannelArray(std::move(channels));
   ServiceWorkerGlobalScopeClient::From(context)->PostMessageToClient(
       uuid_, message_string, std::move(web_channels));
 }
 
 }  // namespace blink