Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(14)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall.https-expected.txt
Issue
2845963002
:
[ServiceWorker] Add type attribute into Client object (Closed)
Patch Set: layout tests
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall.https-expected.txt
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
third_party/WebKit/Source/modules/serviceworkers/Client.idl
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt
('k') |
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt »
('j') |
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This is a testharness.js-based test.
2
FAIL Test Clients.matchAll() assert_array_equals: property 3, expected "window" but got undefined
3
Harness: the test ran to completion.
4
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt
('k') |
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt »
('j') |
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp »
('J')
Issue 2845963002: [ServiceWorker] Add type attribute into Client object (Closed)
Created 3 years, 7 months ago by leonhsl(Using Gerrit)
Modified 3 years, 7 months ago
Reviewers: shimazu, foolip
Base URL:
Comments: 8
This is Rietveld
408576698