Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2845823002: Allow command-line and system Flash when --disable-bundled-pepper-flash. (Closed)

Created:
3 years, 7 months ago by waffles
Modified:
3 years, 7 months ago
Reviewers:
Nico, xhwang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow command-line and system Flash when --disable-bundled-pepper-flash. BUG=715431 Review-Url: https://codereview.chromium.org/2845823002 Cr-Commit-Position: refs/heads/master@{#468801} Committed: https://chromium.googlesource.com/chromium/src/+/e389863c1b80cdfa819bea395fd4d5770c161ee7

Patch Set 1 #

Patch Set 2 : ; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/common/chrome_content_client.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
waffles
xhwang: Please confirm we don't mind if CLI Flash or System Flash is registered when ...
3 years, 7 months ago (2017-04-27 00:20:11 UTC) #6
Nico
owners lgtm
3 years, 7 months ago (2017-04-27 01:18:45 UTC) #7
xhwang
LGTM from disabling the fake Flash's perspective.
3 years, 7 months ago (2017-05-02 21:06:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845823002/20001
3 years, 7 months ago (2017-05-02 21:07:21 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 22:46:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e389863c1b80cdfa819bea395fd4...

Powered by Google App Engine
This is Rietveld 408576698