third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js - Issue 2845813003: [DevTools] Host paint profiles in PaintProfilerModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

Issue 2845813003: [DevTools] Host paint profiles in PaintProfilerModel (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

index 446c177a529920d7205d88fd0156972d9f737966..8aa39fa61c2fb71d70671802aa5f50cb1e970fb5 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

@@ -204,11 +204,11 @@ Timeline.TimelineDetailsView = class extends UI.VBox {

* @param {!SDK.TracingModel.Event} event

_showEventInPaintProfiler(event) {

- const target = SDK.targetManager.mainTarget();

- if (!target)

+ const paintProfilerModel = SDK.targetManager.models(SDK.PaintProfilerModel)[0];

+ if (!paintProfilerModel)

return;

const paintProfilerView = this._paintProfilerView();

- const hasProfileData = paintProfilerView.setEvent(target, event);

+ const hasProfileData = paintProfilerView.setEvent(paintProfilerModel, event);

if (!hasProfileData)

return;

if (this._tabbedPane.hasTab(Timeline.TimelineDetailsView.Tab.PaintProfiler))