Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2845773005: Replace ASSERT_NOT_REACHED with NOTREACHED in core/paint (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1120 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 return IntSize(VerticalScrollbarStart(0, Box().Size().Width().ToInt()), 1131 return IntSize(VerticalScrollbarStart(0, Box().Size().Width().ToInt()),
1132 Box().BorderTop().ToInt()); 1132 Box().BorderTop().ToInt());
1133 } 1133 }
1134 1134
1135 if (&scrollbar == HorizontalScrollbar()) 1135 if (&scrollbar == HorizontalScrollbar())
1136 return IntSize( 1136 return IntSize(
1137 HorizontalScrollbarStart(0), 1137 HorizontalScrollbarStart(0),
1138 (Box().Size().Height() - Box().BorderBottom() - scrollbar.Height()) 1138 (Box().Size().Height() - Box().BorderBottom() - scrollbar.Height())
1139 .ToInt()); 1139 .ToInt());
1140 1140
1141 ASSERT_NOT_REACHED(); 1141 NOTREACHED();
1142 return IntSize(); 1142 return IntSize();
1143 } 1143 }
1144 1144
1145 static inline const LayoutObject& ScrollbarStyleSource( 1145 static inline const LayoutObject& ScrollbarStyleSource(
1146 const LayoutObject& layout_object) { 1146 const LayoutObject& layout_object) {
1147 if (Node* node = layout_object.GetNode()) { 1147 if (Node* node = layout_object.GetNode()) {
1148 if (layout_object.IsLayoutView()) { 1148 if (layout_object.IsLayoutView()) {
1149 Document& doc = node->GetDocument(); 1149 Document& doc = node->GetDocument();
1150 if (Settings* settings = doc.GetSettings()) { 1150 if (Settings* settings = doc.GetSettings()) {
1151 if (!settings->GetAllowCustomScrollbarInMainFrame() && 1151 if (!settings->GetAllowCustomScrollbarInMainFrame() &&
(...skipping 997 matching lines...) Expand 10 before | Expand all | Expand 10 after
2149 2149
2150 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2150 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2151 ClampScrollableAreas() { 2151 ClampScrollableAreas() {
2152 for (auto& scrollable_area : *needs_clamp_) 2152 for (auto& scrollable_area : *needs_clamp_)
2153 scrollable_area->ClampScrollOffsetAfterOverflowChange(); 2153 scrollable_area->ClampScrollOffsetAfterOverflowChange();
2154 delete needs_clamp_; 2154 delete needs_clamp_;
2155 needs_clamp_ = nullptr; 2155 needs_clamp_ = nullptr;
2156 } 2156 }
2157 2157
2158 } // namespace blink 2158 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698