Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2845773004: DO NOT SUBMIT: add main dex list check to classloader. (Closed)

Created:
3 years, 7 months ago by estevenson
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, mikecase+watch_chromium.org, danakj+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, vmpstr+watch_chromium.org, agrieve
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT SUBMIT: add main dex list check to classloader. Fail when isolated processes try to load classes that aren't in the main dex list. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -159 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/FileUtils.java View 2 chunks +18 lines, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/Reflect.java View 9 chunks +25 lines, -12 lines 0 comments Download
A base/android/java/src/org/chromium/base/multidex/ChromiumClassLoader.java View 1 chunk +120 lines, -0 lines 0 comments Download
M base/android/java/templates/BuildConfig.template View 2 chunks +22 lines, -0 lines 0 comments Download
M build/android/gyp/main_dex_list.py View 4 chunks +15 lines, -2 lines 0 comments Download
M build/android/incremental_install/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
D build/android/incremental_install/java/org/chromium/incrementalinstall/Reflect.java View 1 chunk +0 lines, -142 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +12 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 6 chunks +30 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
estevenson
3 years, 7 months ago (2017-04-28 14:45:52 UTC) #1 
Obviously not for review, but here's the CL I started a few months ago.

Powered by Google App Engine
This is Rietveld 408576698