Photo Picker Dialog: Add caching for the decoded images.

chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.photo_picker;
 
 import android.app.Activity;
 import android.content.Context;
+import android.graphics.Bitmap;
 import android.graphics.Rect;
 import android.support.v7.widget.GridLayoutManager;
 import android.support.v7.widget.RecyclerView;
 import android.support.v7.widget.Toolbar.OnMenuItemClickListener;
+import android.util.LruCache;
 import android.view.LayoutInflater;
 import android.view.MenuItem;
 import android.view.View;
 import android.widget.RelativeLayout;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.widget.selection.SelectableListLayout;
 import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
 import org.chromium.ui.PhotoPickerListener;
 
 import java.util.List;
 
 /**
  * A class for keeping track of common data associated with showing photos in
  * the photo picker, for example the RecyclerView and the bitmap caches.
  */
 public class PickerCategoryView extends RelativeLayout
         implements FileEnumWorkerTask.FilesEnumeratedCallback, OnMenuItemClickListener {
+    private static final int KILOBYTE = 1024;
+
     // The dialog that owns us.
     private PhotoPickerDialog mDialog;
 
     // The view containing the RecyclerView and the toolbar, etc.
     private SelectableListLayout<PickerBitmap> mSelectableListLayout;
 
     // Our context.
     private Context mContext;
 
     // The list of images on disk, sorted by last-modified first.
     private List<PickerBitmap> mPickerBitmaps;
 
     // True if multi-selection is allowed in the picker.
     private boolean mMultiSelectionAllowed;
 
     // The callback to notify the listener of decisions reached in the picker.
     private PhotoPickerListener mListener;
 
     // The RecyclerView showing the images.
     private RecyclerView mRecyclerView;
 
     // The {@link PickerAdapter} for the RecyclerView.
     private PickerAdapter mPickerAdapter;
 
     // The {@link SelectionDelegate} keeping track of which images are selected.
     private SelectionDelegate<PickerBitmap> mSelectionDelegate;
 
+    // A low-resolution cache for images. Helpful for cache misses from the high-resolution cache
+    // to avoid showing gray squares (we show pixelated versions instead until image can be loaded
+    // off disk, which is much less jarring).
+    private LruCache<String, Bitmap> mLowResBitmaps;
+
+    // A high-resolution cache for images.
+    private LruCache<String, Bitmap> mHighResBitmaps;

[Michael van Ouwerkerk, 2017/04/27 17:07:35]

What guarantee do we have that these caches do not survive for longer than
needed?

[Finnur, 2017/05/04 16:05:15]

This object is destroyed when the dialog goes away.

+
     /**
      * The number of columns to show. Note: mColumns and mPadding (see below) should both be even
      * numbers or both odd, not a mix (the column padding will not be of uniform thickness if they
      * are a mix).
      */
     private int mColumns;
 
     // The padding between columns. See also comment for mColumns.
     private int mPadding;
 
@@ skipping 31 matching lines @@
 
         Rect appRect = new Rect();
         ((Activity) context).getWindow().getDecorView().getWindowVisibleDisplayFrame(appRect);
         calculateGridMetrics(appRect.width());
 
         RecyclerView.LayoutManager mLayoutManager = new GridLayoutManager(mContext, mColumns);
         mRecyclerView.setHasFixedSize(true);
         mRecyclerView.setLayoutManager(mLayoutManager);
         mRecyclerView.addItemDecoration(new GridSpacingItemDecoration(mColumns, mPadding));
 
-        // TODO(finnur): Implement caching.
+        final int maxMemory = (int) (Runtime.getRuntime().maxMemory() / KILOBYTE);
+        final int cacheSizeLarge = maxMemory / 2; // 1/2 of the available memory.
+        final int cacheSizeSmall = maxMemory / 8; // 1/8th of the available memory.
+        mLowResBitmaps = new LruCache<String, Bitmap>(cacheSizeSmall) {
+            @Override
+            protected int sizeOf(String key, Bitmap bitmap) {
+                return bitmap.getByteCount() / KILOBYTE;
+            }
+        };
+        mHighResBitmaps = new LruCache<String, Bitmap>(cacheSizeLarge) {

[Michael van Ouwerkerk, 2017/04/27 17:07:35]

Please ping memory-dev@chromium.org
https://groups.google.com/a/chromium.org/forum/#!forum/memory-dev to discuss
whether this use case merits hooking into ComponentCallbacks2.onTrimMemory
https://developer.android.com/reference/android/content/ComponentCallbacks2.html

[Finnur, 2017/05/04 16:05:15]

Will do, thanks.

+            @Override
+            protected int sizeOf(String key, Bitmap bitmap) {
+                return bitmap.getByteCount() / KILOBYTE;
+            }
+        };
+
         // TODO(finnur): Remove this once the decoder service is in place.
         prepareBitmaps();
     }
 
     /**
      * Cancels any outstanding requests.
      */
     public void onDialogDismissed() {
         if (mWorkerTask != null) {
             mWorkerTask.cancel(true);
@@ skipping 49 matching lines @@
     }
 
     public SelectionDelegate<PickerBitmap> getSelectionDelegate() {
         return mSelectionDelegate;
     }
 
     public List<PickerBitmap> getPickerBitmaps() {
         return mPickerBitmaps;
     }
 
+    public LruCache<String, Bitmap> getLowResBitmaps() {
+        return mLowResBitmaps;
+    }
+
+    public LruCache<String, Bitmap> getHighResBitmaps() {
+        return mHighResBitmaps;
+    }
+
     public boolean isMultiSelectAllowed() {
         return mMultiSelectionAllowed;
     }
 
     /**
      * Notifies the listener that the user selected to launch the gallery.
      */
     public void showGallery() {
         mListener.onPickerUserAction(PhotoPickerListener.Action.LAUNCH_GALLERY, null);
     }
@@ skipping 78 matching lines @@
                 if (position < mSpanCount) {
                     top = mSpacing;
                 }
                 bottom = mSpacing;
             }
 
             outRect.set(left, top, right, bottom);
         }
     }
 }