Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2845773002: Make TextDecoration an enum class. (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 221444d69c8ce5ad0b0c6ca7ba2efdf2f60a16a8..2f750a462132ea5e7577f140c769ee1725823fc8 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -1495,12 +1495,14 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
// Text decoration properties.
// text-decoration-line
- static TextDecoration InitialTextDecoration() { return kTextDecorationNone; }
+ static TextDecoration InitialTextDecoration() {
+ return TextDecoration::kNone;
+ }
TextDecoration GetTextDecoration() const {
return static_cast<TextDecoration>(visual_data_->text_decoration);
}
void SetTextDecoration(TextDecoration v) {
- SET_VAR(visual_data_, text_decoration, v);
+ SET_VAR(visual_data_, text_decoration, static_cast<unsigned>(v));
Bugs Nash 2017/04/27 00:53:54 as above, I would store this as a TextDecoration o
shend 2017/04/27 01:09:17 Same reasoning as above, we need to pack text_deco
}
// text-decoration-color

Powered by Google App Engine
This is Rietveld 408576698