third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp - Issue 2845773002: Make TextDecoration an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 2845773002: Make TextDecoration an enum class. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

index b29697600454fc8084e3c18a6dccf8a9d188bf41..3d285021190464396dfca1e7affc0be0e8bbc6b0 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

@@ -909,8 +909,8 @@ LayoutUnit InlineFlowBox::FarthestPositionForUnderline(

// If the text decoration isn't in effect on the child, it must be outside

// of |decorationObject|.

- if (!(curr->LineStyleRef().TextDecorationsInEffect() &

- kTextDecorationUnderline))

+ if (!EnumHasFlags(curr->LineStyleRef().TextDecorationsInEffect(),

+ TextDecoration::kUnderline))

continue;

if (decorating_box && decorating_box.IsLayoutInline() &&