third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2845773002: Make TextDecoration an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2845773002: Make TextDecoration an enum class. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 1daf561861fb978098871d665ddc317d8e39a536..0b624fd6dcdafd7ffeca70bcaf6c3178fba1cbc5 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1133,14 +1133,15 @@ static LayoutRect SizingBox(const LayoutObject* layout_object) {

: box->ComputedCSSContentBoxRect();

}

-static CSSValue* RenderTextDecorationFlagsToCSSValue(int text_decoration) {

+static CSSValue* RenderTextDecorationFlagsToCSSValue(

+ TextDecoration text_decoration) {

// Blink value is ignored.

CSSValueList* list = CSSValueList::CreateSpaceSeparated();

- if (text_decoration & kTextDecorationUnderline)

+ if (EnumHasFlags(text_decoration, TextDecoration::kUnderline))

list->Append(*CSSIdentifierValue::Create(CSSValueUnderline));

- if (text_decoration & kTextDecorationOverline)

+ if (EnumHasFlags(text_decoration, TextDecoration::kOverline))

list->Append(*CSSIdentifierValue::Create(CSSValueOverline));

- if (text_decoration & kTextDecorationLineThrough)

+ if (EnumHasFlags(text_decoration, TextDecoration::kLineThrough))

list->Append(*CSSIdentifierValue::Create(CSSValueLineThrough));

if (!list->length())