Make TextDecoration an enum class.

third_party/WebKit/Source/core/style/ComputedStyleConstants.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
@@ skipping 233 matching lines @@
   kLineBreakAfterWhiteSpace
 };
 
 enum EResize { RESIZE_NONE, RESIZE_BOTH, RESIZE_HORIZONTAL, RESIZE_VERTICAL };
 
 enum QuoteType { OPEN_QUOTE, CLOSE_QUOTE, NO_OPEN_QUOTE, NO_CLOSE_QUOTE };
 
 enum EAnimPlayState { kAnimPlayStatePlaying, kAnimPlayStatePaused };
 
 static const size_t kTextDecorationBits = 4;
-enum TextDecoration {
-  kTextDecorationNone = 0x0,
-  kTextDecorationUnderline = 0x1,
-  kTextDecorationOverline = 0x2,
-  kTextDecorationLineThrough = 0x4,
-  kTextDecorationBlink = 0x8
+enum class TextDecoration : unsigned {
+  kNone = 0x0,
+  kUnderline = 0x1,
+  kOverline = 0x2,
+  kLineThrough = 0x4,
+  kBlink = 0x8
 };
 inline TextDecoration operator|(TextDecoration a, TextDecoration b) {
-  return TextDecoration(int(a) | int(b));
+  return static_cast<TextDecoration>(static_cast<unsigned>(a) |
+                                     static_cast<unsigned>(b));
 }
 inline TextDecoration& operator|=(TextDecoration& a, TextDecoration b) {
-  return a = a | b;
+  return a = static_cast<TextDecoration>(static_cast<unsigned>(a) |
+                                         static_cast<unsigned>(b));
+}
+inline TextDecoration& operator^=(TextDecoration& a, TextDecoration b) {
+  return a = static_cast<TextDecoration>(static_cast<unsigned>(a) ^
+                                         static_cast<unsigned>(b));
+}
+inline bool EnumHasFlags(TextDecoration v, TextDecoration mask) {

[Bugs Nash, 2017/04/27 00:02:23]

If this function is only going to be used for TextDecoration then rename to
TextDecorationHasFlags. If other types of enums will need the same functionality
then make this a template.

[shend, 2017/04/27 00:27:33]

Certain other enums will need this as well. I will make this a template.

+  return static_cast<TextDecoration>(static_cast<unsigned>(v) &
+                                     static_cast<unsigned>(mask)) !=
+         TextDecoration::kNone;

[Bugs Nash, 2017/04/27 00:02:23]

I don't think TextDecoration::kNone is exactly what you're wanting to compare to
here (although it happens to also be 0 and will work). I would find this more
readable if it was left as unsigned and compared to 0. But get a second opinion
here.

return static_cast<unsigned>(v) & static_cast<unsigned>(mask))

[shend, 2017/04/27 00:27:33]

Done.

 }
 
 enum TextDecorationStyle {
   kTextDecorationStyleSolid,
   kTextDecorationStyleDouble,
   kTextDecorationStyleDotted,
   kTextDecorationStyleDashed,
   kTextDecorationStyleWavy
 };
 
@@ skipping 229 matching lines @@
   kScrollSnapTypeNone,
   kScrollSnapTypeMandatory,
   kScrollSnapTypeProximity
 };
 
 enum AutoRepeatType { kNoAutoRepeat, kAutoFill, kAutoFit };
 
 }  // namespace blink
 
 #endif  // ComputedStyleConstants_h