third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp - Issue 2845743003: Move "create a module script" from ModuleScriptLoader to ModuleScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp

Issue 2845743003: Move "create a module script" from ModuleScriptLoader to ModuleScript (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ModuleScript.cpp ('k') | third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp b/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp

index 6921f7f72f1f689843ce39a24766e433e3ff853a..e581c4b6c0aec56a4fc4b3e1aa10094a5b0421b4 100644

--- a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp

@@ -61,7 +61,7 @@ ModuleScript* CreateReferrerModuleScript(Modulator* modulator,

scope.GetIsolate(), "import './target.js'; export const a = 42;",

"referrer.js", kSharableCrossOrigin);

KURL referrer_url(kParsedURLString, "https://example.com/referrer.js");

- ModuleScript* referrer_module_script = ModuleScript::Create(

+ ModuleScript* referrer_module_script = ModuleScript::CreateForTest(

modulator, referrer_record, referrer_url, "", kParserInserted,

WebURLRequest::kFetchCredentialsModeOmit);

// TODO(kouhei): moduleScript->setInstantiateSuccess(); once

@@ -76,8 +76,8 @@ ModuleScript* CreateTargetModuleScript(Modulator* modulator,

"target.js", kSharableCrossOrigin);

KURL url(kParsedURLString, "https://example.com/target.js");

ModuleScript* module_script =

- ModuleScript::Create(modulator, record, url, "", kParserInserted,

- WebURLRequest::kFetchCredentialsModeOmit);

+ ModuleScript::CreateForTest(modulator, record, url, "", kParserInserted,

+ WebURLRequest::kFetchCredentialsModeOmit);

// TODO(kouhei): moduleScript->setInstantiateSuccess(); once

// https://codereview.chromium.org/2782403002/ landed.

return module_script;