Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2845693003: Mark external/wpt/media-source/mediasource-{remove,activesourcebuffers}.html tests as flaky (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
pfeldman, pkalinnikov
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark external/wpt/media-source/mediasource-{remove,activesourcebuffers}.html tests as flaky BUG=715718 TBR=pfeldman@chromium.org,pkalinnikov@chromium.org Review-Url: https://codereview.chromium.org/2845693003 . Cr-Commit-Position: refs/heads/master@{#467414} Committed: https://chromium.googlesource.com/chromium/src/+/47e29208adba250e05e256ed3e21b6c84ca7ef22

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
alph
Committed patchset #1 (id:1) manually as 47e29208adba250e05e256ed3e21b6c84ca7ef22 (presubmit successful).
3 years, 8 months ago (2017-04-26 19:38:21 UTC) #2
pkalinnikov
https://codereview.chromium.org/2845693003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2845693003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode3446 third_party/WebKit/LayoutTests/TestExpectations:3446: crbug.com/715718 external/wpt/media-source/mediasource-remove.html [ Failure Pass ] What is the ...
3 years, 7 months ago (2017-04-27 06:28:52 UTC) #3
pkalinnikov
3 years, 7 months ago (2017-04-27 06:38:50 UTC) #4
Message was sent while issue was closed.
Okay, this guide
(https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_t...)
says "The file is not ordered. If you put new changes somewhere in the middle of
the file, this will reduce the chance of merge conflicts when landing your
patch."

I suppose, there is no need to put some sense into the ordering. LGTM.

Powered by Google App Engine
This is Rietveld 408576698