Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: net/proxy/proxy_script_fetcher.h

Issue 2845643003: Allow ProxyService to share URLRequestContext with everything else. (Closed)
Patch Set: Fix fetcher shutdown with no active request, add test, add comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_script_decider_unittest.cc ('k') | net/proxy/proxy_script_fetcher_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_script_fetcher.h
diff --git a/net/proxy/proxy_script_fetcher.h b/net/proxy/proxy_script_fetcher.h
index ed89268352f22a316c64b0259609556391ae8a9a..3905b100babfaf7c9bb4c7e183ad1a37a9f08e4b 100644
--- a/net/proxy/proxy_script_fetcher.h
+++ b/net/proxy/proxy_script_fetcher.h
@@ -54,6 +54,12 @@ class NET_EXPORT_PRIVATE ProxyScriptFetcher {
// Returns the request context that this fetcher uses to issue downloads,
// or NULL.
virtual URLRequestContext* GetRequestContext() const = 0;
+
+ // Fails the in-progress fetch (if any) and future requests will fail
+ // immediately. GetRequestContext() will always return nullptr after this is
+ // called. Must be called before the URLRequestContext the fetcher was
+ // created with is torn down.
+ virtual void OnShutdown() = 0;
};
} // namespace net
« no previous file with comments | « net/proxy/proxy_script_decider_unittest.cc ('k') | net/proxy/proxy_script_fetcher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698