Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: net/proxy/proxy_script_decider.h

Issue 2845643003: Allow ProxyService to share URLRequestContext with everything else. (Closed)
Patch Set: Fix fetcher shutdown with no active request, add test, add comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/mock_proxy_script_fetcher.cc ('k') | net/proxy/proxy_script_decider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_script_decider.h
diff --git a/net/proxy/proxy_script_decider.h b/net/proxy/proxy_script_decider.h
index c4139087d7e74efa699771f2c3468190d79cd526..b3560baa9bdf5eccb1de9ebe150d681da829486c 100644
--- a/net/proxy/proxy_script_decider.h
+++ b/net/proxy/proxy_script_decider.h
@@ -81,6 +81,10 @@ class NET_EXPORT_PRIVATE ProxyScriptDecider {
bool fetch_pac_bytes,
const CompletionCallback& callback);
+ // Shuts down any in-progress DNS requests, and cancels any ScriptFetcher
+ // requests. Does not call OnShutdown on the [Dhcp]ProxyScriptFetcher.
+ void OnShutdown();
+
const ProxyConfig& effective_config() const;
const scoped_refptr<ProxyResolverScriptData>& script_data() const;
@@ -203,7 +207,6 @@ class NET_EXPORT_PRIVATE ProxyScriptDecider {
AddressList wpad_addresses_;
base::OneShotTimer quick_check_timer_;
- HostResolver* host_resolver_;
std::unique_ptr<HostResolver::Request> request_;
base::Time quick_check_start_time_;
« no previous file with comments | « net/proxy/mock_proxy_script_fetcher.cc ('k') | net/proxy/proxy_script_decider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698