net/proxy/dhcp_proxy_script_fetcher.cc - Issue 2845643003: Allow ProxyService to share URLRequestContext with everything else.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_fetcher.cc

Issue 2845643003: Allow ProxyService to share URLRequestContext with everything else. (Closed)

Patch Set: Fix fetcher shutdown with no active request, add test, add comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/dhcp_proxy_script_fetcher.cc

diff --git a/net/proxy/dhcp_proxy_script_fetcher.cc b/net/proxy/dhcp_proxy_script_fetcher.cc

index 1771be05d643ce8ec86704cfbe84c9b410f7ab9c..7c381cac1c2ed4fb1fec19e985394c178a7d684f 100644

--- a/net/proxy/dhcp_proxy_script_fetcher.cc

+++ b/net/proxy/dhcp_proxy_script_fetcher.cc

@@ -27,6 +27,8 @@ int DoNothingDhcpProxyScriptFetcher::Fetch(

void DoNothingDhcpProxyScriptFetcher::Cancel() {}

+void DoNothingDhcpProxyScriptFetcher::OnShutdown() {}

const GURL& DoNothingDhcpProxyScriptFetcher::GetPacURL() const {

return gurl_;

}

« no previous file with comments | « net/proxy/dhcp_proxy_script_fetcher.h ('k') | net/proxy/dhcp_proxy_script_fetcher_win.h » ('j') | no next file with comments »