Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chromeos/network/dhcp_proxy_script_fetcher_chromeos.h

Issue 2845643003: Allow ProxyService to share URLRequestContext with everything else. (Closed)
Patch Set: Fix fetcher shutdown with no active request, add test, add comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/network/dhcp_proxy_script_fetcher_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/dhcp_proxy_script_fetcher_chromeos.h
diff --git a/chromeos/network/dhcp_proxy_script_fetcher_chromeos.h b/chromeos/network/dhcp_proxy_script_fetcher_chromeos.h
index db890267fcfecba28354a59b0456cef9b57d5a71..b61c903118d531c0acb18d3858722e942b13603a 100644
--- a/chromeos/network/dhcp_proxy_script_fetcher_chromeos.h
+++ b/chromeos/network/dhcp_proxy_script_fetcher_chromeos.h
@@ -39,6 +39,7 @@ class CHROMEOS_EXPORT DhcpProxyScriptFetcherChromeos
int Fetch(base::string16* utf16_text,
const net::CompletionCallback& callback) override;
void Cancel() override;
+ void OnShutdown() override;
const GURL& GetPacURL() const override;
std::string GetFetcherName() const override;
@@ -47,7 +48,6 @@ class CHROMEOS_EXPORT DhcpProxyScriptFetcherChromeos
net::CompletionCallback callback,
std::string pac_url);
- net::URLRequestContext* url_request_context_; // Weak ptr
std::unique_ptr<net::ProxyScriptFetcher> proxy_script_fetcher_;
scoped_refptr<base::SingleThreadTaskRunner> network_handler_task_runner_;
« no previous file with comments | « no previous file | chromeos/network/dhcp_proxy_script_fetcher_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698