memory-infra: Remove is_enabled_ from MDM

base/trace_event/memory_dump_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_MANAGER_H_
 #define BASE_TRACE_EVENT_MEMORY_DUMP_MANAGER_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 95 matching lines @@
   // task-runner affinity.
   // This method takes ownership of the dump provider and guarantees that:
   //  - The |mdp| will be deleted at some point in the near future.
   //  - Its deletion will not happen concurrently with the OnMemoryDump() call.
   // Note that OnMemoryDump() and PollFastMemoryTotal() calls can still happen
   // after this method returns.
   void UnregisterAndDeleteDumpProviderSoon(
       std::unique_ptr<MemoryDumpProvider> mdp);
 
   // Requests a memory dump. The dump might happen or not depending on the
   // filters and categories specified when enabling tracing.

[ssid, 2017/05/04 22:00:22]

A SUMMARY_ONLY dump can be requested at any time after initialization and other
type of dumps can be requested only when MDM is enabled.

[hjd, 2017/05/05 14:54:52]

Done.

   // The optional |callback| is executed asynchronously, on an arbitrary thread,
   // to notify about the completion of the global dump (i.e. after all the
   // processes have dumped) and its success (true iff all the dumps were
   // successful).
   void RequestGlobalDump(MemoryDumpType dump_type,
                          MemoryDumpLevelOfDetail level_of_detail,
                          const GlobalMemoryDumpCallback& callback);
 
   // Same as above (still asynchronous), but without callback.
   void RequestGlobalDump(MemoryDumpType dump_type,
                          MemoryDumpLevelOfDetail level_of_detail);
 
   // Prepare MemoryDumpManager for RequestGlobalMemoryDump calls.

[ssid, 2017/05/04 22:00:22]

Prepare MemoryDumpManager for RequestGlobalDump calls for tracing related modes
(non-SUMMARY_ONLY)

[hjd, 2017/05/05 14:54:52]

Done.

   // Starts the MemoryDumpManager thread.

[ssid, 2017/05/04 22:00:22]

This comment is probably stale?

[hjd, 2017/05/05 14:54:52]

Done, thanks!

   // Also uses the given config to initialize the peak detector,

[ssid, 2017/05/04 22:00:22]

Also uses - > Initializes the peak...

[hjd, 2017/05/05 14:54:52]

Done.

   // scheduler and heap profiler.
   void Enable(const TraceConfig::MemoryDumpConfig&);
 
   // Tearsdown the MemoryDumpManager thread and various other state set up by

[ssid, 2017/05/04 22:00:22]

remove the part about Thread.

[hjd, 2017/05/05 14:54:52]

Done.

   // Enable.
   void Disable();
 
   // NOTE: Use RequestGlobalDump() to create memory dumps. Creates a memory dump
   // for the current process and appends it to the trace. |callback| will be
   // invoked asynchronously upon completion on the same thread on which
   // CreateProcessDump() was called. This method should only be used by the
   // embedder while creating a global memory dump.
   void CreateProcessDump(const MemoryDumpRequestArgs& args,
                          const ProcessMemoryDumpCallback& callback);
@@ skipping 154 matching lines @@
   // Function provided by the embedder to handle global dump requests.
   RequestGlobalDumpFunction request_dump_function_;
 
   // True when current process coordinates the periodic dump triggering.
   bool is_coordinator_;
 
   // Protects from concurrent accesses to the local state, eg: to guard against
   // disabling logging while dumping on another thread.
   Lock lock_;
 
-  // Optimization to avoid attempting any memory dump (i.e. to not walk an empty
-  // dump_providers_enabled_ list) when tracing is not enabled.
-  subtle::AtomicWord is_enabled_;
-
   // Thread used for MemoryDumpProviders which don't specify a task runner
   // affinity.
   std::unique_ptr<Thread> dump_thread_;
 
   // The unique id of the child process. This is created only for tracing and is
   // expected to be valid only when tracing is enabled.
   uint64_t tracing_process_id_;
 
   // When true, calling |RegisterMemoryDumpProvider| is a no-op.
   bool dumper_registrations_ignored_for_testing_;
 
   // Whether new memory dump providers should be told to enable heap profiling.
   bool heap_profiling_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(MemoryDumpManager);
 };
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_MEMORY_DUMP_MANAGER_H_