Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: base/trace_event/memory_tracing_observer.cc

Issue 2845633002: memory-infra: Remove is_enabled_ from MDM (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/trace_event/memory_tracing_observer.h" 5 #include "base/trace_event/memory_tracing_observer.h"
6 6
7 #include "base/trace_event/memory_dump_manager.h" 7 #include "base/trace_event/memory_dump_manager.h"
8 #include "base/trace_event/trace_event_argument.h" 8 #include "base/trace_event/trace_event_argument.h"
9 9
10 namespace base { 10 namespace base {
11 namespace trace_event { 11 namespace trace_event {
12 12
13 namespace { 13 namespace {
14 14
15 const int kTraceEventNumArgs = 1; 15 const int kTraceEventNumArgs = 1;
16 const char* kTraceEventArgNames[] = {"dumps"}; 16 const char* kTraceEventArgNames[] = {"dumps"};
17 const unsigned char kTraceEventArgTypes[] = {TRACE_VALUE_TYPE_CONVERTABLE}; 17 const unsigned char kTraceEventArgTypes[] = {TRACE_VALUE_TYPE_CONVERTABLE};
18 18
19 bool IsMemoryInfraTracingEnabled() {
20 bool enabled;
21 TRACE_EVENT_CATEGORY_GROUP_ENABLED(MemoryDumpManager::kTraceCategory,
22 &enabled);
23 return enabled;
24 }
25
26 }; // namespace 19 }; // namespace
27 20
28 MemoryTracingObserver::MemoryTracingObserver( 21 MemoryTracingObserver::MemoryTracingObserver(
29 TraceLog* trace_log, 22 TraceLog* trace_log,
30 MemoryDumpManager* memory_dump_manager) 23 MemoryDumpManager* memory_dump_manager)
31 : memory_dump_manager_(memory_dump_manager), trace_log_(trace_log) { 24 : memory_dump_manager_(memory_dump_manager), trace_log_(trace_log) {
32 // If tracing was enabled before initializing MemoryDumpManager, we missed the 25 // If tracing was enabled before initializing MemoryDumpManager, we missed the
33 // OnTraceLogEnabled() event. Synthetize it so we can late-join the party. 26 // OnTraceLogEnabled() event. Synthetize it so we can late-join the party.
34 // IsEnabled is called before adding observer to avoid calling 27 // IsEnabled is called before adding observer to avoid calling
35 // OnTraceLogEnabled twice. 28 // OnTraceLogEnabled twice.
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_PROCESS_ID( 78 TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_PROCESS_ID(
86 TRACE_EVENT_PHASE_MEMORY_DUMP, 79 TRACE_EVENT_PHASE_MEMORY_DUMP,
87 TraceLog::GetCategoryGroupEnabled(MemoryDumpManager::kTraceCategory), 80 TraceLog::GetCategoryGroupEnabled(MemoryDumpManager::kTraceCategory),
88 event_name, trace_event_internal::kGlobalScope, dump_guid, pid, 81 event_name, trace_event_internal::kGlobalScope, dump_guid, pid,
89 kTraceEventNumArgs, kTraceEventArgNames, kTraceEventArgTypes, 82 kTraceEventNumArgs, kTraceEventArgNames, kTraceEventArgTypes,
90 nullptr /* arg_values */, &event_value, TRACE_EVENT_FLAG_HAS_ID); 83 nullptr /* arg_values */, &event_value, TRACE_EVENT_FLAG_HAS_ID);
91 84
92 return true; 85 return true;
93 } 86 }
94 87
88 bool MemoryTracingObserver::IsMemoryInfraTracingEnabled() {
89 bool enabled;
90 TRACE_EVENT_CATEGORY_GROUP_ENABLED(MemoryDumpManager::kTraceCategory,
91 &enabled);
92 return enabled;
93 }
94
95 } // namespace trace_event 95 } // namespace trace_event
96 } // namespace base 96 } // namespace base
OLDNEW
« base/trace_event/memory_tracing_observer.h ('K') | « base/trace_event/memory_tracing_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698