Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2845613002: Fix the bug that sticky element may not be correctly invalidated due to non-promotion (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/compositing/non-composited-sticky-element-repaint-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 16f625873668c322d216058212ebb91e6e3d0ab5..67cc67149558c7ce349d0749f3d422bbb651603e 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -838,6 +838,11 @@ void PaintLayer::UpdateLayerPosition() {
if (GetLayoutObject().IsInFlowPositioned()) {
LayoutSize new_offset = GetLayoutObject().OffsetForInFlowPosition();
+ if (!HasCompositedLayerMapping() &&
chrishtr 2017/04/28 20:11:43 This is not in general the right place to be doing
yigu 2017/04/28 20:38:56 Suppose we have a region A that needs repaint on s
+ OffsetForInFlowPosition() != new_offset) {
+ GetLayoutObject().SetShouldDoFullPaintInvalidation(
+ kPaintInvalidationLocationChange);
+ }
if (rare_data_ || !new_offset.IsZero())
EnsureRareData().offset_for_in_flow_position = new_offset;
local_point.Move(new_offset);
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/compositing/non-composited-sticky-element-repaint-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698