third_party/WebKit/LayoutTests/paint/invalidation/compositing/non-composited-sticky-element-repaint.html - Issue 2845613002: Fix the bug that sticky element may not be correctly invalidated due to non-promotion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/compositing/non-composited-sticky-element-repaint.html

Issue 2845613002: Fix the bug that sticky element may not be correctly invalidated due to non-promotion (Closed)

Patch Set: Update tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .scroller {

	4 overflow: scroll;

	5 width: 200px;

	6 height: 600px;

	7 }

	8

	9 .composited {

	10 will-change: transform;

	11 }

	12

	13 .box {

	14 background: rgba(0, 255, 0, 0.9);

	15 position: sticky;

	16 width: 100%;

	17 height: 50px;

	18 top: 0px;

	19 }

	20

	21 .container {

	22 width: 100%;

	23 height: 1000px;

	24 background: grey;

	25 }

	26

	27 .spacer {

	28 background: white;

	29 height: 300px;

	30 }

	31 </style>

	32

	33 <div id="scroller" class="scroller">

	34 <div class="composited container">

	35 <div id="box-need-invalidation" class="box"></div>

	36 <div class="spacer"></div>
	yigu 2017/04/27 15:20:10 If this spacer is not composited, e.g. we move it If this spacer is not composited, e.g. we move it out of the composited container, we will invalidate it as scroll if we disable sp invalidation (layout test failure in virtual/disable-spinvalidation/). Is that expected? chrishtr@ WDYT?
	37 <div id="box-not-need-invalidation" class="box"></div>

	38 </div>

	39 </div>

	40

	41 <script src="../resources/text-based-repaint.js"></script>

	42 <script>

	43 // The first box needs to be invalidated but the second sticky box

	44 // does not as it hasn't passed the starting constraint yet.

	45 function repaintTest() {

	46 let scroller = document.getElementById('scroller');

	47 scroller.scrollTop = 200;

	48 }

	49 onload = runRepaintAndPixelTest;

	50 </script>

OLD	NEW