Fix the bug that sticky element may not be correctly invalidated due to non-promotion

third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

 /*
  * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 258 matching lines @@
   bool has_composited_scrolling_ancestor =
       layer->AncestorScrollingLayer() &&
       (compositing_reason_finder_.DirectReasons(layer->AncestorScrollingLayer(),
                                                 false) &
        kCompositingReasonOverflowScrollingTouch);
 
   // TODO(chrishtr): use |hasCompositedScrollingAncestor| instead.
   const bool ignore_lcd_text =
       current_recursion_data.has_composited_scrolling_ancestor_;
   direct_reasons |=
       compositing_reason_finder_.DirectReasons(layer, ignore_lcd_text);

[flackr, 2017/05/12 18:00:46]

I think we should set ignore_lcd_text appropriately here based on compositing
ancestors, rather than add separate promotion trigger logic.

[yigu, 2017/05/17 19:39:06]

Done.

 
   bool can_be_composited = compositor->CanBeComposited(layer);
   if (can_be_composited) {
     reasons_to_composite |= direct_reasons;
 
     if (layer->IsRootLayer() && compositor->RootShouldAlwaysComposite())
       reasons_to_composite |= kCompositingReasonRoot;
 
     // Add CompositingReasonOverflowScrollingTouch for layers that do not
     // already have it but need it.
@@ skipping 75 matching lines @@
   }
 
   reasons_to_composite |= overlap_compositing_reason;
 
   // The children of this layer don't need to composite, unless there is
   // a compositing layer among them, so start by inheriting the compositing
   // ancestor with m_subtreeIsCompositing set to false.
   RecursionData child_recursion_data = current_recursion_data;
   child_recursion_data.subtree_is_compositing_ = false;
 
+  if (layer->SticksToScroller() &&
+      layer->AncestorOverflowLayer()->ScrollsOverflow() &&

[flackr, 2017/05/12 18:00:46]

This seems to be duplicating the promotion logic in
CompositingReasonFinder::NonStyleDeterminedDirectReasons, isn't the right change
to make sure that we pass ignore_lcd_text = true to NonStyleDeterminedReasons
when we have a composited ancestor?

[yigu, 2017/05/17 19:39:05]

Done.

+      current_recursion_data.compositing_ancestor_ &&
+      current_recursion_data.compositing_ancestor_->AncestorScrollingLayer() &&
+      // This is not exact and over-promotes sometimes if
+      // compositing_ancestor_ is not under the same scroller as the sticky
+      // element.
+      !current_recursion_data.compositing_ancestor_->AncestorScrollingLayer()

[flackr, 2017/05/12 18:00:46]

If we have a composited ancestor scrolling layer then ignore_lcd_text should be
true on line 279 leading to promotion of sticky elements.

[yigu, 2017/05/17 19:39:05]

It's possible that a sticky element have a composited ancestor but doesn't have
ancestor scrolling layer. To correct set ignore_lcd_text, I added another
variable
indicating that it has composited ancestor.

+           ->IsRootLayer()) {
+    reasons_to_composite |= kCompositingReasonScrollDependentPosition;
+  }
+
   bool will_be_composited_or_squashed =
       can_be_composited && RequiresCompositingOrSquashing(reasons_to_composite);
   if (will_be_composited_or_squashed) {
     // This layer now acts as the ancestor for kids.
     child_recursion_data.compositing_ancestor_ = layer;
 
     // Here we know that all children and the layer's own contents can blindly
     // paint into this layer's backing, until a descendant is composited. So, we
     // don't need to check for overlap with anything behind this layer.
     overlap_map.BeginNewOverlapTestingContext();
@@ skipping 171 matching lines @@
     descendant_has3d_transform |=
         any_descendant_has3d_transform || layer->Has3DTransform();
   }
 
   // At this point we have finished collecting all reasons to composite this
   // layer.
   layer->SetCompositingReasons(reasons_to_composite);
 }
 
 }  // namespace blink