third_party/WebKit/LayoutTests/compositing/overflow/non-composited-sticky-element-in-main-thread-scrolled-composited-ancestor.html - Issue 2845613002: Fix the bug that sticky element may not be correctly invalidated due to non-promotion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/overflow/non-composited-sticky-element-in-main-thread-scrolled-composited-ancestor.html

Issue 2845613002: Fix the bug that sticky element may not be correctly invalidated due to non-promotion (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/overflow/non-composited-sticky-element-in-main-thread-scrolled-composited-ancestor-expected.html » ('j') | third_party/WebKit/LayoutTests/compositing/overflow/non-composited-sticky-element-in-main-thread-scrolled-composited-ancestor-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 body {

	4 margin: 0;

	5 }

	6

	7 table {

	8 background: red;

	9 }

	10

	11 td, th {

	12 height: 50px;

	13 width: 50px;

	14 padding: 0;

	15 }

	16

	17 th {

	18 background: green;
	flackr 2017/04/26 15:21:01 If the sticky element is known opaque we may promo If the sticky element is known opaque we may promote it automatically. yigu 2017/04/26 21:46:57 Done. Show quoted text On 2017/04/26 15:21:01, flackr wrote: > If the sticky element is known opaque we may promote it automatically. Done.
	19 position: sticky;

	20 top: 0px;

	21 }

	22

	23 .scroller {

	24 width: 100px;

	25 height: 200px;

	26 }

	27

	28 .composited {

	29 will-change: transform;

	30 }

	31 </style>

	32

	33 <script>

	34 function doTest() {

	35 for (let scroller of document.querySelectorAll('.scroller')) {
	flackr 2017/04/26 15:21:01 There's only a single scroller, can just querySele There's only a single scroller, can just querySelector('.scroller') or use an id. yigu 2017/04/26 21:46:57 Done. Show quoted text On 2017/04/26 15:21:01, flackr wrote: > There's only a single scroller, can just querySelector('.scroller') or use an > id. Done.
	36 scroller.scrollTop = 200;

	37 }

	38 }

	39

	40 window.addEventListener('load', function() {

	41 window.requestAnimationFrame(function() {
	flackr 2017/04/26 15:21:00 Doesn't this need to be declared an async test tha Doesn't this need to be declared an async test that waits until done? See https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/... yigu 2017/04/26 21:46:57 Done. Show quoted text On 2017/04/26 15:21:00, flackr wrote: > Doesn't this need to be declared an async test that waits until done? See > https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/... Done.
	42 window.requestAnimationFrame(doTest);

	43 })

	44 });

	45 </script>

	46

	47 <div class="scroller">

	48 <table class="composited">
	flackr 2017/04/26 15:21:01 A simpler test would just be a large composited di A simpler test would just be a large composited div containing a sticky non-composited div. Does it need a table? yigu 2017/04/26 21:46:57 Done. Show quoted text On 2017/04/26 15:21:01, flackr wrote: > A simpler test would just be a large composited div containing a sticky > non-composited div. Does it need a table? Done.
	49 <thead>

	50 <tr><th></th></tr>

	51 </thead>

	52 <tbody>

	53 <tr><td></td></tr>

	54 <tr><td></td></tr>

	55 <tr><td></td></tr>

	56 <tr><td></td></tr>

	57 </tbody>

	58 </table>

	59 </div>

	60

OLD	NEW