Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/zoom/zoom_controller_unittest.cc

Issue 2845593002: Updates Zoom bubble layout and adds +/- buttons (Closed)
Patch Set: Fix compilation error on gcc Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/location_bar/zoom_view.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/zoom/zoom_controller_unittest.cc
diff --git a/chrome/browser/ui/zoom/zoom_controller_unittest.cc b/chrome/browser/ui/zoom/zoom_controller_unittest.cc
index 835867d5817b4e09ed56a54c97a960a27c790fd1..3d4886a3dc7c0c8dc7ac2aae655141fde03a3a25 100644
--- a/chrome/browser/ui/zoom/zoom_controller_unittest.cc
+++ b/chrome/browser/ui/zoom/zoom_controller_unittest.cc
@@ -66,12 +66,10 @@ TEST_F(ZoomControllerTest, Observe_ZoomController) {
NavigateAndCommit(GURL("about:blank"));
+ // Changing from default to default so the bubble should not be shown.
ZoomController::ZoomChangedEventData zoom_change_data1(
- web_contents(),
- old_zoom_level,
- old_zoom_level,
- ZoomController::ZOOM_MODE_ISOLATED,
- true /* can_show_bubble */);
+ web_contents(), old_zoom_level, old_zoom_level,
+ ZoomController::ZOOM_MODE_ISOLATED, false /* can_show_bubble */);
{
ZoomChangedWatcher zoom_change_watcher1(zoom_controller_.get(),
« no previous file with comments | « chrome/browser/ui/views/location_bar/zoom_view.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698