Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm

Issue 2845593002: Updates Zoom bubble layout and adds +/- buttons (Closed)
Patch Set: Fix ZoomController to never show the bubble when zoom level is not changed from default Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm b/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
index 5c963a61f87fa67c9507ca9d6fe65e6058fc0af5..c6b035c9e12eb55ade3b8b17f9fe643767067e5f 100644
--- a/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
+++ b/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
@@ -120,10 +120,11 @@ IN_PROC_BROWSER_TEST_P(ZoomDecorationTest, BubbleAtDefaultZoom) {
EXPECT_TRUE(zoom_decoration->IsVisible());
zoom_decoration->ShowBubble(false);
Zoom(content::PAGE_ZOOM_RESET);
- EXPECT_FALSE(zoom_decoration->IsVisible());
+ EXPECT_TRUE(zoom_decoration->IsVisible());
// Hide bubble and verify the decoration is hidden.
zoom_decoration->CloseBubble();
+ content::RunAllPendingInMessageLoop();
EXPECT_FALSE(zoom_decoration->IsVisible());
}
@@ -146,6 +147,7 @@ IN_PROC_BROWSER_TEST_P(ZoomDecorationTest, IconRemainsVisibleAfterBubble) {
// Close bubble and verify the decoration is still visible.
zoom_decoration->CloseBubble();
+ content::RunAllPendingInMessageLoop();
EXPECT_TRUE(zoom_decoration->IsVisible());
// Verify the decoration does go away when we expect it to.

Powered by Google App Engine
This is Rietveld 408576698