Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4111)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 2845593002: Updates Zoom bubble layout and adds +/- buttons (Closed)
Patch Set: Always shows zoom icon, even when zoom is 100% (rebased) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 284f8672adcee772b35cd6d0e4879e2190544d6c..ceeff6c1b60c9900ac8b7de745e5afc343339c9b 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -320,9 +320,10 @@ void LocationBarView::ZoomChangedForActiveTab(bool can_show_bubble) {
}
WebContents* web_contents = GetWebContents();
- if (can_show_bubble && zoom_view_->visible() && web_contents)
+ if (can_show_bubble && web_contents) {
ZoomBubbleView::ShowBubble(web_contents, gfx::Point(),
ZoomBubbleView::AUTOMATIC);
+ }
}
void LocationBarView::SetStarToggled(bool on) {
@@ -701,8 +702,6 @@ bool LocationBarView::RefreshZoomView() {
return false;
const bool was_visible = zoom_view_->visible();
zoom_view_->Update(zoom::ZoomController::FromWebContents(web_contents));
- if (!zoom_view_->visible())
- ZoomBubbleView::CloseCurrentBubble();
return was_visible != zoom_view_->visible();
}

Powered by Google App Engine
This is Rietveld 408576698