Updates Zoom bubble layout and adds +/- buttons

chrome/browser/ui/views/harmony/harmony_layout_provider.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/harmony/harmony_layout_provider.h"
 
 gfx::Insets HarmonyLayoutProvider::GetInsetsMetric(int metric) const {
   DCHECK_LT(metric, views::VIEWS_INSETS_MAX);
   switch (metric) {
     case views::INSETS_DIALOG_BUTTON:
@@ skipping 78 matching lines @@
 
 bool HarmonyLayoutProvider::ShouldShowWindowIcon() const {
   return false;
 }
 
 bool HarmonyLayoutProvider::IsHarmonyMode() const {
   return true;
 }
 
 int HarmonyLayoutProvider::GetSnappedDialogWidth(int min_width) const {
-  for (int snap_point : {320, 448, 512}) {
+  for (int snap_point : {220, 320, 448, 512}) {

[Peter Kasting, 2017/04/28 05:58:48]

Don't add this, as this isn't a Harmony snap point.

This surface should not be snapped to any width.  Are you seeing it snapped to
320?  I thought this would not have a dialog delegate.  Maybe this is a case
where we need to add the virtual override for dialogs to ask not to be snapped,
which Elly had suggested when adding dialog snapping?  I'd check with
ellyjones/tapted about this if you're seeing dialog snapping.

[varkha, 2017/04/28 06:21:19]

Yes the dialog was snapping to 320 and this went away when I added another snap
point.
I thought this snapping made sense since the zoom percent label could have
different width.

[Peter Kasting, 2017/04/28 06:47:26]

One problem is that this isn't a snap width in the spec, and adding it here will
affect every dialog in Chrome.

If you're trying to force the label to have a constant width, I'd do that by
adjusting how the zoom bubble computes the label position and the dialog
preferred size, e.g. by measuring the width needed to actually show "100%".

[varkha, 2017/05/01 10:11:59]

Done.

     if (min_width <= snap_point)
       return snap_point;
   }
 
   return ((min_width + kHarmonyLayoutUnit - 1) / kHarmonyLayoutUnit) *
          kHarmonyLayoutUnit;
 }
 
 const views::TypographyProvider& HarmonyLayoutProvider::GetTypographyProvider()
     const {
   return typography_provider_;
 }