third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2845583002: Remove FrameViewBase as base class of RemoteFrameView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2845583002: Remove FrameViewBase as base class of RemoteFrameView. (Closed)

Patch Set: ConvertSelfToChild take FrameOrPlugin as arg Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLPlugInElement.h ('K') | « third_party/WebKit/Source/core/layout/LayoutPart.cpp ('k') | third_party/WebKit/Source/core/plugins/PluginView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index be89186618379733becce7107e6ef7f3e41ab966..d06b8c13aa79086e0c7794132847ad34fae24188 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -1005,8 +1005,9 @@ Region ScrollingCoordinator::ComputeShouldHandleScrollGestureOnMainThreadRegion(

}

- if (const FrameView::PluginsSet* plugins = frame_view->Plugins()) {

- for (const Member<PluginView>& plugin : *plugins) {

+ for (const auto& child : frame_view->Children()) {

+ if (child->IsPluginView()) {

+ PluginView* plugin = ToPluginView(child);

if (plugin->WantsWheelEvents()) {

IntRect box = frame_view->ConvertToRootFrame(plugin->FrameRect());

should_handle_scroll_gesture_on_main_thread_region.Unite(box);