Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrameView.h

Issue 2845583002: Remove FrameViewBase as base class of RemoteFrameView. (Closed)
Patch Set: ConvertSelfToChild take FrameOrPlugin as arg Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrameView.h
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrameView.h b/third_party/WebKit/Source/core/frame/RemoteFrameView.h
index 8fd5c98a706d7ef6bbb0d3bee2ba608c579430f2..96a32581a30f80fe7d597e3c1faf004bbdf2c7bc 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrameView.h
+++ b/third_party/WebKit/Source/core/frame/RemoteFrameView.h
@@ -7,7 +7,6 @@
#include "core/frame/FrameOrPlugin.h"
#include "core/frame/FrameView.h"
-#include "platform/FrameViewBase.h"
#include "platform/geometry/IntRect.h"
#include "platform/heap/Handle.h"
@@ -18,7 +17,6 @@ class GraphicsContext;
class RemoteFrame;
class RemoteFrameView final : public GarbageCollectedFinalized<RemoteFrameView>,
- public FrameViewBase,
public FrameOrPlugin {
USING_GARBAGE_COLLECTED_MIXIN(RemoteFrameView);
@@ -27,9 +25,8 @@ class RemoteFrameView final : public GarbageCollectedFinalized<RemoteFrameView>,
~RemoteFrameView() override;
- bool IsRemoteFrameView() const override { return true; }
- void SetParent(FrameViewBase*) override;
- FrameViewBase* Parent() const override { return parent_; }
+ void SetParent(FrameView*) override;
+ FrameView* Parent() const override { return parent_; }
RemoteFrame& GetFrame() const {
DCHECK(remote_frame_);
@@ -42,14 +39,11 @@ class RemoteFrameView final : public GarbageCollectedFinalized<RemoteFrameView>,
void InvalidateRect(const IntRect&);
void SetFrameRect(const IntRect&) override;
const IntRect& FrameRect() const override { return frame_rect_; }
- IntPoint Location() const override { return frame_rect_.Location(); }
void Paint(GraphicsContext&, const CullRect&) const override {}
void Hide() override;
void Show() override;
void SetParentVisible(bool) override;
- IntRect ConvertFromContainingFrameViewBase(const IntRect&) const override;
-
void UpdateRemoteViewportIntersection();
DECLARE_VIRTUAL_TRACE();
@@ -57,6 +51,8 @@ class RemoteFrameView final : public GarbageCollectedFinalized<RemoteFrameView>,
private:
explicit RemoteFrameView(RemoteFrame*);
+ IntRect ConvertFromRootFrame(const IntRect&) const;
+
// The properties and handling of the cycle between RemoteFrame
// and its RemoteFrameView corresponds to that between LocalFrame
// and FrameView. Please see the FrameView::m_frame comment for
@@ -69,12 +65,6 @@ class RemoteFrameView final : public GarbageCollectedFinalized<RemoteFrameView>,
bool parent_visible_;
};
-DEFINE_TYPE_CASTS(RemoteFrameView,
- FrameViewBase,
- frameViewBase,
- frameViewBase->IsRemoteFrameView(),
- frameViewBase.IsRemoteFrameView());
-
} // namespace blink
#endif // RemoteFrameView_h

Powered by Google App Engine
This is Rietveld 408576698