Remove FrameViewBase as base class of RemoteFrameView.

third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

 /**
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 75 matching lines @@
       should_prefer_plug_ins_for_images_(prefer_plug_ins_for_images_option ==
                                          kShouldPreferPlugInsForImages) {}
 
 HTMLPlugInElement::~HTMLPlugInElement() {
   DCHECK(plugin_wrapper_.IsEmpty());  // cleared in detachLayoutTree()
   DCHECK(!is_delaying_load_event_);
 }
 
 DEFINE_TRACE(HTMLPlugInElement) {
   visitor->Trace(image_loader_);
-  visitor->Trace(plugin_);
   visitor->Trace(persisted_plugin_);
   HTMLFrameOwnerElement::Trace(visitor);
 }
 
-void HTMLPlugInElement::SetPlugin(PluginView* plugin) {
-  if (plugin == plugin_)
-    return;
-
-  // Remove and dispose the old plugin if we had one.
-  if (plugin_) {
-    GetDocument().View()->RemovePlugin(plugin_);
-    DisposeFrameOrPluginSoon(plugin_);
-  }
-  plugin_ = plugin;
-
-  // TODO(joelhockey): I copied the rest of this method from
-  // HTMLFrameOwnerElement.  There may be parts that can be removed
-  // such as the layoutPartItem.isNull check and DCHECKs.
-  // Once widget tree is removed (FrameView::m_children), try to unify
-  // this code with HTMLFrameOwnerElement::setWidget.
-  LayoutPart* layout_part = ToLayoutPart(GetLayoutObject());
-  LayoutPartItem layout_part_item = LayoutPartItem(layout_part);
-  if (layout_part_item.IsNull())
-    return;
-
-  // Update layout and frame with new plugin.
-  if (plugin_) {
-    layout_part_item.UpdateOnWidgetChange();
-
-    DCHECK_EQ(GetDocument().View(), layout_part_item.GetFrameView());
-    DCHECK(layout_part_item.GetFrameView());
-    GetDocument().View()->AddPlugin(plugin);
-  }
-
-  // Apparently accessibility objects might have been modified if plugin
-  // was removed.
-  if (AXObjectCache* cache = GetDocument().ExistingAXObjectCache())
-    cache->ChildrenChanged(layout_part);
-}
-
-PluginView* HTMLPlugInElement::ReleasePlugin() {
-  if (!plugin_)
-    return nullptr;
-  GetDocument().View()->RemovePlugin(plugin_);
-  LayoutPart* layout_part = ToLayoutPart(GetLayoutObject());
-  if (layout_part) {
-    if (AXObjectCache* cache = GetDocument().ExistingAXObjectCache())
-      cache->ChildrenChanged(layout_part);
-  }
-  return plugin_.Release();
-}
-
 void HTMLPlugInElement::SetPersistedPlugin(PluginView* plugin) {
   if (persisted_plugin_ == plugin)
     return;
   if (persisted_plugin_) {
     persisted_plugin_->Hide();
     DisposeFrameOrPluginSoon(persisted_plugin_.Release());
   }
   persisted_plugin_ = plugin;
 }
 
 void HTMLPlugInElement::SetFocused(bool focused, WebFocusType focus_type) {
-  if (plugin_)
-    plugin_->SetFocused(focused, focus_type);
+  PluginView* plugin = OwnedPlugin();
+  if (plugin)
+    plugin->SetFocused(focused, focus_type);
   HTMLFrameOwnerElement::SetFocused(focused, focus_type);
 }
 
 bool HTMLPlugInElement::RequestObjectInternal(
     const String& url,
     const String& mime_type,
     const Vector<String>& param_names,
     const Vector<String>& param_values) {
   if (url.IsEmpty() && mime_type.IsEmpty())
     return false;
@@ skipping 29 matching lines @@
 
 bool HTMLPlugInElement::WillRespondToMouseClickEvents() {
   if (IsDisabledFormControl())
     return false;
   LayoutObject* r = GetLayoutObject();
   return r && (r->IsEmbeddedObject() || r->IsLayoutPart());
 }
 
 void HTMLPlugInElement::RemoveAllEventListeners() {
   HTMLFrameOwnerElement::RemoveAllEventListeners();
-  if (plugin_) {
-    plugin_->EventListenersRemoved();
-  }
+  PluginView* plugin = OwnedPlugin();
+  if (plugin)
+    plugin->EventListenersRemoved();
 }
 
 void HTMLPlugInElement::DidMoveToNewDocument(Document& old_document) {
   if (image_loader_)
     image_loader_->ElementDidMoveToNewDocument();
   HTMLFrameOwnerElement::DidMoveToNewDocument(old_document);
 }
 
 void HTMLPlugInElement::AttachLayoutTree(const AttachContext& context) {
   HTMLFrameOwnerElement::AttachLayoutTree(context);
@@ skipping 78 matching lines @@
 
   param_names.push_back("type");
   param_values.push_back(service_type_);
 
   bool use_fallback = false;
   LoadPlugin(url, service_type_, param_names, param_values, use_fallback,
              false);
 }
 
 bool HTMLPlugInElement::ShouldAccelerate() const {
-  return plugin_ && plugin_->PlatformLayer();
+  PluginView* plugin = OwnedPlugin();
+  return plugin && plugin->PlatformLayer();
 }
 
 void HTMLPlugInElement::DetachLayoutTree(const AttachContext& context) {
   // Update the FrameViewBase the next time we attach (detaching destroys the
   // plugin).
   // FIXME: None of this "needsPluginUpdate" related code looks right.
   if (GetLayoutObject() && !UseFallbackContent())
     SetNeedsPluginUpdate(true);
 
   if (is_delaying_load_event_) {
     is_delaying_load_event_ = false;
     GetDocument().DecrementLoadEventDelayCount();
   }
 
   // Only try to persist a plugin we actually own.
-  if (plugin_ && context.performing_reattach) {
-    SetPersistedPlugin(ReleasePlugin());
+  PluginView* plugin = OwnedPlugin();
+  if (plugin && context.performing_reattach) {
+    SetPersistedPlugin(ToPluginView(ReleaseWidget()));
   } else {
     // Clear the plugin; will trigger disposal of it with Oilpan.
-    SetPlugin(nullptr);
+    SetWidget(nullptr);
   }
 
   ResetInstance();
 
   HTMLFrameOwnerElement::DetachLayoutTree(context);
 }
 
 LayoutObject* HTMLPlugInElement::CreateLayoutObject(
     const ComputedStyle& style) {
   // Fallback content breaks the DOM->layoutObject class relationship of this
@@ skipping 32 matching lines @@
     return v8::Local<v8::Object>();
 
   // If the host dynamically turns off JavaScript (or Java) we will still
   // return the cached allocated Bindings::Instance. Not supporting this
   // edge-case is OK.
   v8::Isolate* isolate = V8PerIsolateData::MainThreadIsolate();
   if (plugin_wrapper_.IsEmpty()) {
     PluginView* plugin;
 
     if (persisted_plugin_)
-      plugin = persisted_plugin_.Get();
+      plugin = persisted_plugin_;
     else
       plugin = PluginWidget();
 
     if (plugin)
       plugin_wrapper_.Reset(isolate, plugin->ScriptableObject(isolate));
   }
   return plugin_wrapper_.Get(isolate);
 }
 
 PluginView* HTMLPlugInElement::PluginWidget() const {
   if (LayoutPart* layout_part = LayoutPartForJSBindings())
     return layout_part->Plugin();
   return nullptr;
 }
 
-PluginView* HTMLPlugInElement::Plugin() const {
-  return plugin_.Get();
+PluginView* HTMLPlugInElement::OwnedPlugin() const {
+  FrameOrPlugin* frame_or_plugin = OwnedWidget();
+  if (frame_or_plugin && frame_or_plugin->IsPluginView())
+    return ToPluginView(frame_or_plugin);
+  return nullptr;
 }
 
 bool HTMLPlugInElement::IsPresentationAttribute(
     const QualifiedName& name) const {
   if (name == widthAttr || name == heightAttr || name == vspaceAttr ||
       name == hspaceAttr || name == alignAttr)
     return true;
   return HTMLFrameOwnerElement::IsPresentationAttribute(name);
 }
 
@@ skipping 31 matching lines @@
   // code in EventHandler; these code paths should be united.
 
   LayoutObject* r = GetLayoutObject();
   if (!r || !r->IsLayoutPart())
     return;
   if (r->IsEmbeddedObject()) {
     if (LayoutEmbeddedItem(ToLayoutEmbeddedObject(r))
             .ShowsUnavailablePluginIndicator())
       return;
   }
-  if (!plugin_)
+  PluginView* plugin = OwnedPlugin();
+  if (!plugin)
     return;
-  plugin_->HandleEvent(event);
+  plugin->HandleEvent(event);
   if (event->DefaultHandled())
     return;
   HTMLFrameOwnerElement::DefaultEventHandler(event);
 }
 
 LayoutPart* HTMLPlugInElement::LayoutPartForJSBindings() const {
   // Needs to load the plugin immediatedly because this function is called
   // when JavaScript code accesses the plugin.
   // FIXME: Check if dispatching events here is safe.
   GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets(
@@ skipping 107 matching lines @@
   LayoutEmbeddedItem layout_item = GetLayoutEmbeddedItem();
   // FIXME: This code should not depend on layoutObject!
   if ((layout_item.IsNull() && require_layout_object) || use_fallback)
     return false;
 
   VLOG(1) << this << " Plugin URL: " << url_;
   VLOG(1) << "Loaded URL: " << url.GetString();
   loaded_url_ = url;
 
   if (persisted_plugin_) {
-    SetPlugin(persisted_plugin_.Release());
+    SetWidget(persisted_plugin_.Release());
   } else {
     bool load_manually =
         GetDocument().IsPluginDocument() && !GetDocument().ContainsPlugins();
     LocalFrameClient::DetachedPluginPolicy policy =
         require_layout_object ? LocalFrameClient::kFailOnDetachedPlugin
                               : LocalFrameClient::kAllowDetachedPlugin;
     PluginView* plugin = frame->Loader().Client()->CreatePlugin(
         this, url, param_names, param_values, mime_type, load_manually, policy);
     if (!plugin) {
       if (!layout_item.IsNull() &&
           !layout_item.ShowsUnavailablePluginIndicator()) {
         plugin_is_available_ = false;
         layout_item.SetPluginAvailability(LayoutEmbeddedObject::kPluginMissing);
       }
       return false;
     }
 
     if (!layout_item.IsNull())
-      SetPlugin(plugin);
+      SetWidget(plugin);
     else
       SetPersistedPlugin(plugin);
   }
 
   GetDocument().SetContainsPlugins();
   // TODO(esprehn): WebPluginContainerImpl::setWebLayer also schedules a
   // compositing update, do we need both?
   SetNeedsCompositingUpdate();
   // Make sure any input event handlers introduced by the plugin are taken into
   // account.
@@ skipping 93 matching lines @@
 
 void HTMLPlugInElement::LazyReattachIfNeeded() {
   if (!UseFallbackContent() && NeedsPluginUpdate() && GetLayoutObject() &&
       !IsImageType()) {
     LazyReattachIfAttached();
     SetPersistedPlugin(nullptr);
   }
 }
 
 }  // namespace blink