cc: Change tile manager perftest to use layers.

cc: Change tile manager perftest to use layers.

Before this patch, the tile manager perftest would directly register
the tiles into tile manager in order to test. This provided accurate
numbers with regards to the number of tiles we had registered, but
it also coupled the knowledge that tile manager deals with tiles
directly.

This patch adds a bit of indirection to the perftest to create layers
that have tiles, and then call manage tiles. This decouples tile manager
from the perftest in the sense that the tile manager is free to choose
what it does with layers/tiles as the perftest better represents the
real world.

NOTE TO PERF SHERIFFS
---------------------

Please note that this changes TileManager perftest. In particular,
any changes in graphs to cc_perftests.manage_tiles should be
disregarded. This patch completely reworks the perftest, so
the results are not comparable to previous results.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270922

[vmpstr, 2014-05-12 17:21:49]

Please take a look.

[enne (OOO), 2014-05-12 18:42:58]

lgtm in general

https://codereview.chromium.org/284553002/diff/10001/cc/resources/tile_manage...
File cc/resources/tile_manager_perftest.cc (right):

https://codereview.chromium.org/284553002/diff/10001/cc/resources/tile_manage...
cc/resources/tile_manager_perftest.cc:218: std::vector<LayerImpl*>
CreateLayers(unsigned layer_count,
style nit: unsigned => int

https://codereview.chromium.org/284553002/diff/10001/cc/resources/tile_manage...
cc/resources/tile_manager_perftest.cc:251: layers.push_back(pending_layer_);
Can you rename this to pending_root_layer_?

It's also a little unclear to me why it needs to be stored as a member variable,
but...

[vmpstr, 2014-05-12 21:35:50]

https://codereview.chromium.org/284553002/diff/10001/cc/resources/tile_manage...
File cc/resources/tile_manager_perftest.cc (right):

https://codereview.chromium.org/284553002/diff/10001/cc/resources/tile_manage...
cc/resources/tile_manager_perftest.cc:218: std::vector<LayerImpl*>
CreateLayers(unsigned layer_count,
On 2014/05/12 18:42:58, enne wrote:
> style nit: unsigned => int

Done.

https://codereview.chromium.org/284553002/diff/10001/cc/resources/tile_manage...
cc/resources/tile_manager_perftest.cc:251: layers.push_back(pending_layer_);
On 2014/05/12 18:42:58, enne wrote:
> Can you rename this to pending_root_layer_?
> 

Done.

> It's also a little unclear to me why it needs to be stored as a member
variable,
> but...

It's also being used for other tests, and in general any test here would create
it using SetupDefaultTrees, so it seems better to just keep it as a member

[vmpstr, 2014-05-13 17:42:31]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-13 17:43:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/284553002/30001

[commit-bot: I haz the power, 2014-05-13 18:11:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[vmpstr, 2014-05-13 18:12:46]

The CQ bit was unchecked by vmpstr@chromium.org

[vmpstr, 2014-05-13 18:20:08]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-13 18:21:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/284553002/50001

[vmpstr, 2014-05-13 21:46:42]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-13 22:04:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/284553002/70001

[commit-bot: I haz the power, 2014-05-14 00:05:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[commit-bot: I haz the power, 2014-05-14 00:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 00:12:00]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[vmpstr, 2014-05-14 19:49:25]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-14 19:50:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/284553002/70001

[commit-bot: I haz the power, 2014-05-14 21:10:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[commit-bot: I haz the power, 2014-05-14 21:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 21:22:59]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[vmpstr, 2014-05-15 23:42:37]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-15 23:42:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/284553002/80001

[commit-bot: I haz the power, 2014-05-16 02:52:27]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-05-16 04:09:41]

Change committed as 270922