Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: content/renderer/skia_benchmarking_extension.cc

Issue 2845463002: gin: Create a DataObjectBuilder class to help create simple data objects. (Closed)
Patch Set: data_object_builder.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/binding_generating_native_handler.cc » ('j') | gin/data_object_builder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/skia_benchmarking_extension.cc
diff --git a/content/renderer/skia_benchmarking_extension.cc b/content/renderer/skia_benchmarking_extension.cc
index 2c42944b8031d354e9904c711b3a5efdbef5ba54..3e2974bba2973a7fa9607678916052317b3fc384 100644
--- a/content/renderer/skia_benchmarking_extension.cc
+++ b/content/renderer/skia_benchmarking_extension.cc
@@ -15,6 +15,7 @@
#include "content/public/renderer/chrome_object_extensions_utils.h"
#include "content/renderer/render_thread_impl.h"
#include "gin/arguments.h"
+#include "gin/data_object_builder.h"
#include "gin/handle.h"
#include "gin/object_template_builder.h"
#include "skia/ext/benchmarking_canvas.h"
@@ -258,16 +259,12 @@ void SkiaBenchmarking::Rasterize(gin::Arguments* args) {
buffer_pixels[i + 3] = SkGetPackedA32(c);
}
- v8::Local<v8::Object> result = v8::Object::New(isolate);
- result->Set(v8::String::NewFromUtf8(isolate, "width"),
- v8::Number::New(isolate, snapped_clip.width()));
- result->Set(v8::String::NewFromUtf8(isolate, "height"),
- v8::Number::New(isolate, snapped_clip.height()));
- result->Set(v8::String::NewFromUtf8(isolate, "data"),
- blink::WebArrayBufferConverter::ToV8Value(
- &buffer, context->Global(), isolate));
-
- args->Return(result);
+ args->Return(gin::DataObjectBuilder(isolate)
+ .Set("width", snapped_clip.width())
+ .Set("height", snapped_clip.height())
+ .Set("data", blink::WebArrayBufferConverter::ToV8Value(
+ &buffer, context->Global(), isolate))
+ .Finish());
}
void SkiaBenchmarking::GetOps(gin::Arguments* args) {
« no previous file with comments | « no previous file | extensions/renderer/binding_generating_native_handler.cc » ('j') | gin/data_object_builder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698