Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 284543002: Display different icons for different device types. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, Noam Samuel
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Display different icons for different device types. BUG=372423 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269965

Patch Set 1 #

Patch Set 2 : Mon 05/12/2014 14:11:41.20 #

Patch Set 3 : Mon 05/12/2014 14:15:39.40 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.css View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 1 2 3 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-12 16:28:57 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-12 16:29:05 UTC) #2
Noam Samuel
lgtm
6 years, 7 months ago (2014-05-12 17:41:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/284543002/1
6 years, 7 months ago (2014-05-12 17:42:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 18:14:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 18:17:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/3433) android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/141536) chromium_presubmit ...
6 years, 7 months ago (2014-05-12 18:17:18 UTC) #7
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-12 21:14:45 UTC) #8
Lei Zhang
lgtm++
6 years, 7 months ago (2014-05-12 21:48:19 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-12 21:51:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/284543002/40001
6 years, 7 months ago (2014-05-12 21:51:55 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 01:55:09 UTC) #12
Message was sent while issue was closed.
Change committed as 269965

Powered by Google App Engine
This is Rietveld 408576698