third_party/WebKit/Source/core/html/ImageData.h - Issue 2845193002: Refactor ImageBitmap constructor from ImageData to be color managed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/ImageData.h

Issue 2845193002: Refactor ImageBitmap constructor from ImageData to be color managed

Patch Set: local commit - all working except unpremultiply Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/ImageData.h

diff --git a/third_party/WebKit/Source/core/html/ImageData.h b/third_party/WebKit/Source/core/html/ImageData.h

index 8d03a8cfafa7eb749ecd461cf7f4062f976ebb02..573d09d42948fb85d96a003b0cd3dab998f245b2 100644

--- a/third_party/WebKit/Source/core/html/ImageData.h

+++ b/third_party/WebKit/Source/core/html/ImageData.h

@@ -134,10 +134,12 @@ class CORE_EXPORT ImageData final : public GarbageCollectedFinalized<ImageData>,

DOMArrayBufferBase* BufferBase() const;

- sk_sp<SkColorSpace> GetSkColorSpace();

+ CanvasColorParams GetCanvasColorParams();

bool ImageDataInCanvasColorSettings(const CanvasColorSpace&,

const CanvasPixelFormat&,

std::unique_ptr<uint8_t[]>&);

+ bool ImageDataInCanvasColorSettings(const CanvasColorParams&,

+ std::unique_ptr<uint8_t[]>&);

// ImageBitmapSource implementation

IntSize BitmapSourceSize() const override { return size_; }