Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: test/mjsunit/es6/string-replace.js

Issue 2845153002: [string] Fix null handling in MaybeCallFunctionAtSymbol (Closed)
Patch Set: Clarify comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-string-gen.cc ('k') | test/mjsunit/es6/string-split.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var pattern = { 5 var pattern = {
6 [Symbol.replace]: (string, newValue) => string + newValue 6 [Symbol.replace]: (string, newValue) => string + newValue,
7 toString: () => "c"
7 }; 8 };
8 // Check object coercible fails. 9 // Check object coercible fails.
9 assertThrows(() => String.prototype.replace.call(null, pattern, "x"), 10 assertThrows(() => String.prototype.replace.call(null, pattern, "x"),
10 TypeError); 11 TypeError);
11 // Override is called. 12 // Override is called.
12 assertEquals("abcdex", "abcde".replace(pattern, "x")); 13 assertEquals("abcdex", "abcde".replace(pattern, "x"));
13 // Non-callable override. 14 // Non-callable override.
14 pattern[Symbol.replace] = "dumdidum"; 15 pattern[Symbol.replace] = "dumdidum";
15 assertThrows(() => "abcde".replace(pattern, "x"), TypeError); 16 assertThrows(() => "abcde".replace(pattern, "x"), TypeError);
17 // Null override.
18 pattern[Symbol.replace] = null;
19 assertEquals("abXde", "abcde".replace(pattern, "X"));
16 20
17 assertEquals("[Symbol.replace]", RegExp.prototype[Symbol.replace].name); 21 assertEquals("[Symbol.replace]", RegExp.prototype[Symbol.replace].name);
OLDNEW
« no previous file with comments | « src/builtins/builtins-string-gen.cc ('k') | test/mjsunit/es6/string-split.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698