LayoutTests/media/avtrack/video-track-selected.html - Issue 284513003: Implement AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/avtrack/video-track-selected.html

Issue 284513003: Implement AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: global-constructors-listing-expected Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/media/avtrack/getTrackById.html ('K') | « LayoutTests/media/avtrack/getTrackById.html ('k') | LayoutTests/webexposed/global-constructors-listing-expected.txt » ('j') | Source/core/html/track/AudioTrack.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>VideoTrack.selected change</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="../media-file.js"></script>

	8 </head>

	9 <body>

	10 <div id="log"></div>

	11 <script>

	12 async_test(function(t)

	13 {

	14 var e = document.createElement("video");

	15 e.src = findMediaFile("video", "../content/test");

	16

	17 e.onloadedmetadata = t.step_func(function()

	18 {

	19 assert_equals(e.videoTracks.length, 1, "videoTracks.length") ;

	20 assert_equals(e.videoTracks.selectedIndex, 0, "videoTracks.s electedIndex (initial)");

	21 assert_true(e.videoTracks[0].selected, "videoTrack.selected (initial)");

	22 e.videoTracks[0].selected = false;

	23 assert_equals(e.videoTracks.selectedIndex, -1, "videoTracks. selectedIndex (first setter)");

	24 assert_false(e.videoTracks[0].selected, "videoTrack.selected (first setter)");

	25

	26 e.videoTracks.onchange = t.unreached_func("setting selected to false fired change event");
	acolwell GONE FROM CHROMIUM 2014/06/13 17:43:57 Interesting. Do you know why the spec doesn't requ Interesting. Do you know why the spec doesn't require a change event here? It seems like going from having a selected video track to having nothing selected would trigger an event. I'm fine with landing this since it is what the spec says, but you might want to file a spec bug about this if you think this case should be changed. philipj_slow 2014/06/14 13:51:03 I think it's strange too, so here's a new bug: htt Show quoted text On 2014/06/13 17:43:57, acolwell wrote: > Interesting. Do you know why the spec doesn't require a change event here? It > seems like going from having a selected video track to having nothing selected > would trigger an event. I'm fine with landing this since it is what the spec > says, but you might want to file a spec bug about this if you think this case > should be changed. I think it's strange too, so here's a new bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26095 It's a trivial fix, so I'll follow up when/if the spec changes.
	27 setTimeout(t.step_func(function()

	28 {

	29 e.videoTracks[0].selected = true;

	30 assert_equals(e.videoTracks.selectedIndex, 0, "videoTrac ks.selectedIndex (second setter)");

	31 assert_true(e.videoTracks[0].selected, "videoTrack.selec ted (second setter)");

	32

	33 e.videoTracks.onchange = t.step_func(function()

	34 {

	35 assert_equals(e.videoTracks.selectedIndex, 0, "video Tracks.selectedIndex (change event)");

	36 assert_true(e.videoTracks[0].selected, "videoTrack.s elected (change event)");

	37 t.done();

	38 });

	39 }), 0);

	40 });

	41 }, "VideoTrackList track change");

	42 </script>

	43 </body>

	44 </html>

OLD	NEW